On 04/21/2014 12:02 PM, Jianyu Zhan wrote:
> Hi, Yanfei,
>
> On Mon, Apr 21, 2014 at 9:00 AM, Zhang Yanfei
> wrote:
>> What should be exported?
>>
>> lru_cache_add()
>> lru_cache_add_anon()
>> lru_cache_add_file()
>>
>> It seems you only export lru_cache_add_file() in the patch.
>
> Right, lru_
Hi, Yanfei,
On Mon, Apr 21, 2014 at 9:00 AM, Zhang Yanfei
wrote:
> What should be exported?
>
> lru_cache_add()
> lru_cache_add_anon()
> lru_cache_add_file()
>
> It seems you only export lru_cache_add_file() in the patch.
Right, lru_cache_add_anon() is only used by VM code, so it should not
be
Hi Jianyu
On 04/18/2014 11:39 PM, Jianyu Zhan wrote:
> Hi, Christoph Hellwig,
>
>> There are no modular users of lru_cache_add, so please don't needlessly
>> export it.
>
> yep, I re-checked and found there is no module user of neither
> lru_cache_add() nor lru_cache_add_anon(), so don't export
On 04/18/2014 11:39 AM, Jianyu Zhan wrote:
> Hi, Christoph Hellwig,
>
>> There are no modular users of lru_cache_add, so please don't needlessly
>> export it.
>
> yep, I re-checked and found there is no module user of neither
> lru_cache_add() nor lru_cache_add_anon(), so don't export it.
>
> H
Hi, Christoph Hellwig,
>There are no modular users of lru_cache_add, so please don't needlessly
>export it.
yep, I re-checked and found there is no module user of neither
lru_cache_add() nor lru_cache_add_anon(), so don't export it.
Here is the renewed patch:
---
In mm/swap.c, __lru_cache_add(
On Fri, Apr 18, 2014 at 09:09:51PM +0800, Jianyu Zhan wrote:
> In mm/swap.c, __lru_cache_add() is exported, but actually there are
> no users outside this file. However, lru_cache_add() is supposed to
> be used by vfs, or whatever others, but it is not exported.
There are no modular users of lru_c
In mm/swap.c, __lru_cache_add() is exported, but actually there are
no users outside this file. However, lru_cache_add() is supposed to
be used by vfs, or whatever others, but it is not exported.
This patch exports lru_cache_add(), and makes __lru_cache_add()
static. It also exports lru_cache_add_
7 matches
Mail list logo
