Re: [PATCH] mm/vmscan: drop unneeded assignment in kswapd()

2020-10-05 Thread Mel Gorman
On Mon, Oct 05, 2020 at 08:58:53AM +0200, Lukas Bulwahn wrote: > > > On Sun, 4 Oct 2020, Mel Gorman wrote: > > > On Sun, Oct 04, 2020 at 02:58:27PM +0200, Lukas Bulwahn wrote: > > > The refactoring to kswapd() in commit e716f2eb24de ("mm, vmscan: prevent > > > kswapd sleeping prematurely due to

Re: [PATCH] mm/vmscan: drop unneeded assignment in kswapd()

2020-10-05 Thread Mel Gorman
On Mon, Oct 05, 2020 at 08:58:53AM +0200, Lukas Bulwahn wrote: > > > On Sun, 4 Oct 2020, Mel Gorman wrote: > > > On Sun, Oct 04, 2020 at 02:58:27PM +0200, Lukas Bulwahn wrote: > > > The refactoring to kswapd() in commit e716f2eb24de ("mm, vmscan: prevent > > > kswapd sleeping prematurely due to

Re: [PATCH] mm/vmscan: drop unneeded assignment in kswapd()

2020-10-05 Thread Lukas Bulwahn
On Sun, 4 Oct 2020, Mel Gorman wrote: > On Sun, Oct 04, 2020 at 02:58:27PM +0200, Lukas Bulwahn wrote: > > The refactoring to kswapd() in commit e716f2eb24de ("mm, vmscan: prevent > > kswapd sleeping prematurely due to mismatched classzone_idx") turned an > > assignment to reclaim_order into a

Re: [PATCH] mm/vmscan: drop unneeded assignment in kswapd()

2020-10-04 Thread Mel Gorman
On Sun, Oct 04, 2020 at 02:58:27PM +0200, Lukas Bulwahn wrote: > The refactoring to kswapd() in commit e716f2eb24de ("mm, vmscan: prevent > kswapd sleeping prematurely due to mismatched classzone_idx") turned an > assignment to reclaim_order into a dead store, as in all further paths, >

[PATCH] mm/vmscan: drop unneeded assignment in kswapd()

2020-10-04 Thread Lukas Bulwahn
The refactoring to kswapd() in commit e716f2eb24de ("mm, vmscan: prevent kswapd sleeping prematurely due to mismatched classzone_idx") turned an assignment to reclaim_order into a dead store, as in all further paths, reclaim_order will be assigned again before it is used. make clang-analyzer on