Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-06 Thread Michal Hocko
On Tue 06-04-21 23:12:34, Neil Sun wrote: > > > On 2021/4/6 22:39, Michal Hocko wrote: > > > > Have you considered using high limit for the pro-active memory reclaim? > > Thanks, Michal, do you mean the procfs interfaces? > We have set vm.vfs_cache_pressure=1000 and so on. > would you please ta

Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-06 Thread Neil Sun
On 2021/4/6 22:39, Michal Hocko wrote: Have you considered using high limit for the pro-active memory reclaim? Thanks, Michal, do you mean the procfs interfaces? We have set vm.vfs_cache_pressure=1000 and so on. would you please take an example? -- Neil

Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-06 Thread Michal Hocko
On Tue 06-04-21 22:34:02, Neil Sun wrote: > > > On 2021/4/6 19:39, Michal Hocko wrote: > > On Tue 06-04-21 19:30:22, Neil Sun wrote: > > > On 2021/4/6 15:21, Michal Hocko wrote: > > > > > > > > You are changing semantic of the existing user interface. This knob has > > > > never been memcg aware

Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-06 Thread Neil Sun
On 2021/4/6 19:39, Michal Hocko wrote: On Tue 06-04-21 19:30:22, Neil Sun wrote: On 2021/4/6 15:21, Michal Hocko wrote: You are changing semantic of the existing user interface. This knob has never been memcg aware and it is supposed to have a global impact. I do not think we can simply cha

Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-06 Thread Michal Hocko
On Tue 06-04-21 19:30:22, Neil Sun wrote: > On 2021/4/6 15:21, Michal Hocko wrote: > > > > You are changing semantic of the existing user interface. This knob has > > never been memcg aware and it is supposed to have a global impact. I do > > not think we can simply change that without some users

Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-06 Thread Michal Hocko
On Fri 02-04-21 18:38:54, Neil Sun wrote: > This patch makes shrink_slab() with task's memcg in drop_slab_node(), > so we can free reclaimable slab objects belongs to memcg /lxc/i-vbe1u8o7 > with following command: You are changing semantic of the existing user interface. This knob has never been

Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-02 Thread kernel test robot
Hi Neil, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.12-rc5] [also build test ERROR on next-20210401] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--

Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-02 Thread kernel test robot
Hi Neil, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.12-rc5] [also build test ERROR on next-20210401] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--

[PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-02 Thread Neil Sun
This patch makes shrink_slab() with task's memcg in drop_slab_node(), so we can free reclaimable slab objects belongs to memcg /lxc/i-vbe1u8o7 with following command: cgexec -g memory:/lxc/i-vbe1u8o7 sysctl vm.drop_caches=2 Test with following steps: root@i-yl0pwrt8:~# free -h tota