Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-03 Thread Daniel Jordan
On Wed, Jun 03, 2020 at 10:06:31AM +0530, Anshuman Khandual wrote: > Does this look okay and sufficient ? > > --- a/Documentation/vm/page_migration.rst > +++ b/Documentation/vm/page_migration.rst > @@ -253,5 +253,20 @@ which are function pointers of struct > address_space_operations. >

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-03 Thread Matthew Wilcox
On Wed, Jun 03, 2020 at 10:28:41AM +0530, Anshuman Khandual wrote: > On 06/03/2020 08:27 AM, Matthew Wilcox wrote: > > On Wed, Jun 03, 2020 at 06:56:57AM +0530, Anshuman Khandual wrote: > >> On 06/02/2020 08:31 PM, Matthew Wilcox wrote: > >>> On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-02 Thread Anshuman Khandual
On 06/03/2020 08:27 AM, Matthew Wilcox wrote: > On Wed, Jun 03, 2020 at 06:56:57AM +0530, Anshuman Khandual wrote: >> On 06/02/2020 08:31 PM, Matthew Wilcox wrote: >>> On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: This adds the following two new VM events which will

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-02 Thread Anshuman Khandual
On 06/02/2020 08:22 PM, Daniel Jordan wrote: > On Mon, Jun 01, 2020 at 09:48:09PM -0700, John Hubbard wrote: >> However, the fact that this is under discussion hints at the need for a >> bit of documentation help. What do you think about adding some notes about >> all of this to, say,

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-02 Thread Matthew Wilcox
On Wed, Jun 03, 2020 at 06:56:57AM +0530, Anshuman Khandual wrote: > On 06/02/2020 08:31 PM, Matthew Wilcox wrote: > > On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: > >> This adds the following two new VM events which will help in validating PMD > >> based THP migration

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-02 Thread Anshuman Khandual
On 06/02/2020 08:31 PM, Matthew Wilcox wrote: > On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: >> This adds the following two new VM events which will help in validating PMD >> based THP migration without split. Statistics reported through these events >> will help in

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-02 Thread Matthew Wilcox
On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: > This adds the following two new VM events which will help in validating PMD > based THP migration without split. Statistics reported through these events > will help in performance debugging. > > 1. THP_PMD_MIGRATION_SUCCESS >

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-02 Thread Daniel Jordan
On Mon, Jun 01, 2020 at 09:48:09PM -0700, John Hubbard wrote: > However, the fact that this is under discussion hints at the need for a > bit of documentation help. What do you think about adding some notes about > all of this to, say, Documentation/vm/page_migration.rst ? Yes, that would be

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-01 Thread Anshuman Khandual
On 06/02/2020 10:18 AM, John Hubbard wrote: > On 2020-06-01 21:20, Anshuman Khandual wrote: > ... >>> also important: maybe this patch should also be tracking other causes >>> of THP PMD migration failure, in order to get a truer accounting of the >>> situation. > > I hope one of the experts

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-01 Thread John Hubbard
On 2020-06-01 21:20, Anshuman Khandual wrote: ... also important: maybe this patch should also be tracking other causes of THP PMD migration failure, in order to get a truer accounting of the situation. I hope one of the experts here can weigh in on that... Is there any other failure reasons

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-01 Thread Anshuman Khandual
On 06/02/2020 08:50 AM, John Hubbard wrote: > On 2020-06-01 09:57, Daniel Jordan wrote: >> Hi Anshuman, >> >> On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: >>> This adds the following two new VM events which will help in validating PMD >>> based THP migration without split.

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-01 Thread John Hubbard
On 2020-06-01 09:57, Daniel Jordan wrote: Hi Anshuman, On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: This adds the following two new VM events which will help in validating PMD based THP migration without split. Statistics reported through these events will help in

Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-06-01 Thread Daniel Jordan
Hi Anshuman, On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: > This adds the following two new VM events which will help in validating PMD > based THP migration without split. Statistics reported through these events > will help in performance debugging. > > 1.

[PATCH] mm/vmstat: Add events for PMD based THP migration without split

2020-05-21 Thread Anshuman Khandual
This adds the following two new VM events which will help in validating PMD based THP migration without split. Statistics reported through these events will help in performance debugging. 1. THP_PMD_MIGRATION_SUCCESS 2. THP_PMD_MIGRATION_FAILURE Cc: Naoya Horiguchi Cc: Zi Yan Cc: John Hubbard