Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-14 Thread Sergey Senozhatsky
On (06/13/16 15:49), Ganesh Mahendran wrote: [..] > > some parts (of the info above) are already available: zram maps to > > pool name, which maps to a sysfs file name, that can contain the rest. > > I'm just trying to understand what kind of optimizations we are talking > > about here and how woul

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-13 Thread Ganesh Mahendran
2016-06-13 13:12 GMT+08:00 Sergey Senozhatsky : > Hello, > > On (06/13/16 13:42), Minchan Kim wrote: > [..] >> > compacted(total 0) */ >> > 2) # 1351.241 us | } >> > -- >> > => 1351.241 us used >> > >> > And it seems the overhead of function_graph is bigger than trace event. >> > >> > bash-36

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-12 Thread Ganesh Mahendran
2016-06-13 12:42 GMT+08:00 Minchan Kim : > On Wed, Jun 08, 2016 at 02:39:19PM +0800, Ganesh Mahendran wrote: > > > >> zsmalloc is not only used by zram, but also zswap. Maybe >> others in the future. >> >> I tried to use function_graph. It seems there are too much log >> printed: >> -- >> root

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-12 Thread Sergey Senozhatsky
Hello, On (06/13/16 13:42), Minchan Kim wrote: [..] > > compacted(total 0) */ > > 2) # 1351.241 us | } > > -- > > => 1351.241 us used > > > > And it seems the overhead of function_graph is bigger than trace event. > > > > bash-3682 [002] 1439.180646: zsmalloc_compact_start: pool zra

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-12 Thread Minchan Kim
On Wed, Jun 08, 2016 at 02:39:19PM +0800, Ganesh Mahendran wrote: > zsmalloc is not only used by zram, but also zswap. Maybe > others in the future. > > I tried to use function_graph. It seems there are too much log > printed: > -- > root@leo-test:/sys/kernel/debug/tracing# cat trace > # tr

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-12 Thread Minchan Kim
On Tue, Jun 07, 2016 at 04:56:44PM +0800, Ganesh Mahendran wrote: > Currently zsmalloc is widely used in android device. > Sometimes, we want to see how frequently zs_compact is > triggered or how may pages freed by zs_compact(), or which > zsmalloc pool is compacted. > > Most of the time, user ca

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-12 Thread Ganesh Mahendran
Hi, Sergey: 2016-06-08 22:10 GMT+08:00 Sergey Senozhatsky : > Hello, > > On (06/08/16 14:39), Ganesh Mahendran wrote: >> >> > On Tue, Jun 07, 2016 at 04:56:44PM +0800, Ganesh Mahendran wrote: >> >> >> Currently zsmalloc is widely used in android device. >> >> >> Sometimes, we want to see how frequ

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-08 Thread Sergey Senozhatsky
Hello, On (06/08/16 14:39), Ganesh Mahendran wrote: > >> > On Tue, Jun 07, 2016 at 04:56:44PM +0800, Ganesh Mahendran wrote: > >> >> Currently zsmalloc is widely used in android device. > >> >> Sometimes, we want to see how frequently zs_compact is > >> >> triggered or how may pages freed by zs_co

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-07 Thread Ganesh Mahendran
Hi, Minchan: 2016-06-08 13:13 GMT+08:00 Minchan Kim : > On Wed, Jun 08, 2016 at 09:48:30AM +0800, Ganesh Mahendran wrote: >> Hi, Minchan: >> >> 2016-06-08 8:16 GMT+08:00 Minchan Kim : >> > Hello Ganesh, >> > >> > On Tue, Jun 07, 2016 at 04:56:44PM +0800, Ganesh Mahendran wrote: >> >> Currently zsm

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-07 Thread Minchan Kim
On Wed, Jun 08, 2016 at 09:48:30AM +0800, Ganesh Mahendran wrote: > Hi, Minchan: > > 2016-06-08 8:16 GMT+08:00 Minchan Kim : > > Hello Ganesh, > > > > On Tue, Jun 07, 2016 at 04:56:44PM +0800, Ganesh Mahendran wrote: > >> Currently zsmalloc is widely used in android device. > >> Sometimes, we want

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-07 Thread Ganesh Mahendran
Hi, Minchan: 2016-06-08 8:16 GMT+08:00 Minchan Kim : > Hello Ganesh, > > On Tue, Jun 07, 2016 at 04:56:44PM +0800, Ganesh Mahendran wrote: >> Currently zsmalloc is widely used in android device. >> Sometimes, we want to see how frequently zs_compact is >> triggered or how may pages freed by zs_com

Re: [PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-07 Thread Minchan Kim
Hello Ganesh, On Tue, Jun 07, 2016 at 04:56:44PM +0800, Ganesh Mahendran wrote: > Currently zsmalloc is widely used in android device. > Sometimes, we want to see how frequently zs_compact is > triggered or how may pages freed by zs_compact(), or which > zsmalloc pool is compacted. > > Most of th

[PATCH] mm/zsmalloc: add trace events for zs_compact

2016-06-07 Thread Ganesh Mahendran
Currently zsmalloc is widely used in android device. Sometimes, we want to see how frequently zs_compact is triggered or how may pages freed by zs_compact(), or which zsmalloc pool is compacted. Most of the time, user can get the brief information from trace_mm_shrink_slab_[start | end], but in so