Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

2015-12-22 Thread David Rientjes
On Wed, 16 Dec 2015, Oleg Nesterov wrote: > clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), > VM_SOFTDIRTY was already cleared before walk_page_range(). > > Signed-off-by: Oleg Nesterov Acked-by: David Rientjes -- To unsubscribe from this list: send the line

Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

2015-12-22 Thread David Rientjes
On Wed, 16 Dec 2015, Oleg Nesterov wrote: > clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), > VM_SOFTDIRTY was already cleared before walk_page_range(). > > Signed-off-by: Oleg Nesterov Acked-by: David Rientjes -- To

Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

2015-12-16 Thread Cyrill Gorcunov
On Wed, Dec 16, 2015 at 06:26:32PM +0100, Oleg Nesterov wrote: > clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), > VM_SOFTDIRTY was already cleared before walk_page_range(). > > Signed-off-by: Oleg Nesterov Acked-by: Cyrill Gorcunov Thank you! -- To unsubscribe

Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

2015-12-16 Thread Kirill A. Shutemov
On Wed, Dec 16, 2015 at 06:26:32PM +0100, Oleg Nesterov wrote: > clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), > VM_SOFTDIRTY was already cleared before walk_page_range(). Not only that, We shouldn't [generally] change vm_flags without exclusive mmap_sem and we have

[PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

2015-12-16 Thread Oleg Nesterov
clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), VM_SOFTDIRTY was already cleared before walk_page_range(). Signed-off-by: Oleg Nesterov --- fs/proc/task_mmu.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/fs/proc/task_mmu.c

[PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

2015-12-16 Thread Oleg Nesterov
clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), VM_SOFTDIRTY was already cleared before walk_page_range(). Signed-off-by: Oleg Nesterov --- fs/proc/task_mmu.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

2015-12-16 Thread Cyrill Gorcunov
On Wed, Dec 16, 2015 at 06:26:32PM +0100, Oleg Nesterov wrote: > clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), > VM_SOFTDIRTY was already cleared before walk_page_range(). > > Signed-off-by: Oleg Nesterov Acked-by: Cyrill Gorcunov

Re: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd()

2015-12-16 Thread Kirill A. Shutemov
On Wed, Dec 16, 2015 at 06:26:32PM +0100, Oleg Nesterov wrote: > clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), > VM_SOFTDIRTY was already cleared before walk_page_range(). Not only that, We shouldn't [generally] change vm_flags without exclusive mmap_sem and we have