Re: [PATCH] mm: Cleanup in do_shrink_slab()

2018-07-19 Thread Kirill Tkhai
On 19.07.2018 19:21, David Laight wrote: > From: Kirill Tkhai >> Sent: 19 July 2018 17:05 >> >> Group long variables together to minimize number of occupied lines >> and place all definitions in back Christmas tree order. > > Grouping together unrelated variables doesn't really make the code > any

RE: [PATCH] mm: Cleanup in do_shrink_slab()

2018-07-19 Thread David Laight
From: Kirill Tkhai > Sent: 19 July 2018 17:05 > > Group long variables together to minimize number of occupied lines > and place all definitions in back Christmas tree order. Grouping together unrelated variables doesn't really make the code any more readable. IMHO One variable per line is usuall

Re: [PATCH] mm: Cleanup in do_shrink_slab()

2018-07-19 Thread Shakeel Butt
On Thu, Jul 19, 2018 at 9:04 AM Kirill Tkhai wrote: > > Group long variables together to minimize number of occupied lines > and place all definitions in back Christmas tree order. Also, > simplify expression around batch_size: use all power of C language! > > Signed-off-by: Kirill Tkhai Reviewe

[PATCH] mm: Cleanup in do_shrink_slab()

2018-07-19 Thread Kirill Tkhai
Group long variables together to minimize number of occupied lines and place all definitions in back Christmas tree order. Also, simplify expression around batch_size: use all power of C language! Signed-off-by: Kirill Tkhai --- mm/vmscan.c | 11 +++ 1 file changed, 3 insertions(+), 8