Re: [PATCH] mm: Fix comment for NODEMASK_ALLOC

2018-08-23 Thread Oscar Salvador
On Tue, Aug 21, 2018 at 01:51:59PM -0700, Andrew Morton wrote: > On Tue, 21 Aug 2018 14:30:24 +0200 Oscar Salvador > wrote: > > > On Tue, Aug 21, 2018 at 02:17:34PM +0200, Michal Hocko wrote: > > > We do have CONFIG_NODES_SHIFT=10 in our SLES kernels for quite some > > > time (around SLE11-SP3 A

Re: [PATCH] mm: Fix comment for NODEMASK_ALLOC

2018-08-21 Thread Andrew Morton
On Tue, 21 Aug 2018 14:30:24 +0200 Oscar Salvador wrote: > On Tue, Aug 21, 2018 at 02:17:34PM +0200, Michal Hocko wrote: > > We do have CONFIG_NODES_SHIFT=10 in our SLES kernels for quite some > > time (around SLE11-SP3 AFAICS). > > > > Anyway, isn't NODES_ALLOC over engineered a bit? Does actu

Re: [PATCH] mm: Fix comment for NODEMASK_ALLOC

2018-08-21 Thread Oscar Salvador
On Tue, Aug 21, 2018 at 02:51:56PM +0200, Michal Hocko wrote: > On Tue 21-08-18 14:30:24, Oscar Salvador wrote: > > On Tue, Aug 21, 2018 at 02:17:34PM +0200, Michal Hocko wrote: > > > We do have CONFIG_NODES_SHIFT=10 in our SLES kernels for quite some > > > time (around SLE11-SP3 AFAICS). > > > >

Re: [PATCH] mm: Fix comment for NODEMASK_ALLOC

2018-08-21 Thread Michal Hocko
On Tue 21-08-18 14:30:24, Oscar Salvador wrote: > On Tue, Aug 21, 2018 at 02:17:34PM +0200, Michal Hocko wrote: > > We do have CONFIG_NODES_SHIFT=10 in our SLES kernels for quite some > > time (around SLE11-SP3 AFAICS). > > > > Anyway, isn't NODES_ALLOC over engineered a bit? Does actually even do

Re: [PATCH] mm: Fix comment for NODEMASK_ALLOC

2018-08-21 Thread Oscar Salvador
On Tue, Aug 21, 2018 at 02:17:34PM +0200, Michal Hocko wrote: > We do have CONFIG_NODES_SHIFT=10 in our SLES kernels for quite some > time (around SLE11-SP3 AFAICS). > > Anyway, isn't NODES_ALLOC over engineered a bit? Does actually even do > larger than 1024 NUMA nodes? This would be 128B and fro

Re: [PATCH] mm: Fix comment for NODEMASK_ALLOC

2018-08-21 Thread Michal Hocko
On Mon 20-08-18 14:24:40, Andrew Morton wrote: > On Mon, 20 Aug 2018 10:55:16 +0200 Oscar Salvador > wrote: > > > From: Oscar Salvador > > > > Currently, NODEMASK_ALLOC allocates a nodemask_t with kmalloc when > > NODES_SHIFT is higher than 8, otherwise it declares it within the stack. > > >

Re: [PATCH] mm: Fix comment for NODEMASK_ALLOC

2018-08-20 Thread Andrew Morton
On Mon, 20 Aug 2018 10:55:16 +0200 Oscar Salvador wrote: > From: Oscar Salvador > > Currently, NODEMASK_ALLOC allocates a nodemask_t with kmalloc when > NODES_SHIFT is higher than 8, otherwise it declares it within the stack. > > The comment says that the reasoning behind this, is that nodema

[PATCH] mm: Fix comment for NODEMASK_ALLOC

2018-08-20 Thread Oscar Salvador
From: Oscar Salvador Currently, NODEMASK_ALLOC allocates a nodemask_t with kmalloc when NODES_SHIFT is higher than 8, otherwise it declares it within the stack. The comment says that the reasoning behind this, is that nodemask_t will be 256 bytes when NODES_SHIFT is higher than 8, but this is no