Re: [PATCH] mm: Fix kobject memleak in SLUB

2019-04-30 Thread Tobin C. Harding
On Sun, Apr 28, 2019 at 09:40:00AM +1000, Tobin C. Harding wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin

Re: [PATCH] mm: Fix kobject memleak in SLUB

2019-04-28 Thread Greg Kroah-Hartman
On Sun, Apr 28, 2019 at 09:40:00AM +1000, Tobin C. Harding wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin

Re: [PATCH] mm: Fix kobject memleak in SLUB

2019-04-28 Thread Pekka Enberg
On 28/04/2019 2.40, Tobin C. Harding wrote: Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak. Add call to kobject_put() in error path of kobject_init_and_add(). Signed-off-by: Tobin C. Harding Reviewed-by:

[PATCH] mm: Fix kobject memleak in SLUB

2019-04-27 Thread Tobin C. Harding
Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak. Add call to kobject_put() in error path of kobject_init_and_add(). Signed-off-by: Tobin C. Harding --- mm/slub.c | 4 +++- 1 file changed, 3 insertions(+), 1