Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-11-30 Thread Kirill Tkhai
On 30.11.2017 03:27, Shakeel Butt wrote: > On Fri, Sep 29, 2017 at 1:15 AM, Kirill Tkhai wrote: >> On 29.09.2017 00:02, Andrew Morton wrote: >>> On Thu, 28 Sep 2017 10:48:55 +0300 Kirill Tkhai >>> wrote: >>> >> This patch aims to make

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-11-30 Thread Kirill Tkhai
On 30.11.2017 03:27, Shakeel Butt wrote: > On Fri, Sep 29, 2017 at 1:15 AM, Kirill Tkhai wrote: >> On 29.09.2017 00:02, Andrew Morton wrote: >>> On Thu, 28 Sep 2017 10:48:55 +0300 Kirill Tkhai >>> wrote: >>> >> This patch aims to make super_cache_count() (and other functions, >> which

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-11-29 Thread Shakeel Butt
On Fri, Sep 29, 2017 at 1:15 AM, Kirill Tkhai wrote: > On 29.09.2017 00:02, Andrew Morton wrote: >> On Thu, 28 Sep 2017 10:48:55 +0300 Kirill Tkhai wrote: >> > This patch aims to make super_cache_count() (and other functions, > which count LRU

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-11-29 Thread Shakeel Butt
On Fri, Sep 29, 2017 at 1:15 AM, Kirill Tkhai wrote: > On 29.09.2017 00:02, Andrew Morton wrote: >> On Thu, 28 Sep 2017 10:48:55 +0300 Kirill Tkhai wrote: >> > This patch aims to make super_cache_count() (and other functions, > which count LRU nr_items) more effective. > It allows

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-29 Thread Kirill Tkhai
On 29.09.2017 00:02, Andrew Morton wrote: > On Thu, 28 Sep 2017 10:48:55 +0300 Kirill Tkhai wrote: > This patch aims to make super_cache_count() (and other functions, which count LRU nr_items) more effective. It allows list_lru_node::memcg_lrus to be

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-29 Thread Kirill Tkhai
On 29.09.2017 00:02, Andrew Morton wrote: > On Thu, 28 Sep 2017 10:48:55 +0300 Kirill Tkhai wrote: > This patch aims to make super_cache_count() (and other functions, which count LRU nr_items) more effective. It allows list_lru_node::memcg_lrus to be RCU-accessed, and makes

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-28 Thread Andrew Morton
On Thu, 28 Sep 2017 10:48:55 +0300 Kirill Tkhai wrote: > >> This patch aims to make super_cache_count() (and other functions, > >> which count LRU nr_items) more effective. > >> It allows list_lru_node::memcg_lrus to be RCU-accessed, and makes > >> __list_lru_count_one()

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-28 Thread Andrew Morton
On Thu, 28 Sep 2017 10:48:55 +0300 Kirill Tkhai wrote: > >> This patch aims to make super_cache_count() (and other functions, > >> which count LRU nr_items) more effective. > >> It allows list_lru_node::memcg_lrus to be RCU-accessed, and makes > >> __list_lru_count_one() count nr_items lockless

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-28 Thread Kirill Tkhai
On 28.09.2017 00:15, Andrew Morton wrote: > On Tue, 19 Sep 2017 18:06:33 +0300 Kirill Tkhai wrote: > >> During the reclaiming slab of a memcg, shrink_slab iterates >> over all registered shrinkers in the system, and tries to count >> and consume objects related to the

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-28 Thread Kirill Tkhai
On 28.09.2017 00:15, Andrew Morton wrote: > On Tue, 19 Sep 2017 18:06:33 +0300 Kirill Tkhai wrote: > >> During the reclaiming slab of a memcg, shrink_slab iterates >> over all registered shrinkers in the system, and tries to count >> and consume objects related to the cgroup. In case of memory

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-27 Thread Andrew Morton
On Tue, 19 Sep 2017 18:06:33 +0300 Kirill Tkhai wrote: > During the reclaiming slab of a memcg, shrink_slab iterates > over all registered shrinkers in the system, and tries to count > and consume objects related to the cgroup. In case of memory > pressure, this behaves

Re: [PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-27 Thread Andrew Morton
On Tue, 19 Sep 2017 18:06:33 +0300 Kirill Tkhai wrote: > During the reclaiming slab of a memcg, shrink_slab iterates > over all registered shrinkers in the system, and tries to count > and consume objects related to the cgroup. In case of memory > pressure, this behaves bad: I observe high

[PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-19 Thread Kirill Tkhai
During the reclaiming slab of a memcg, shrink_slab iterates over all registered shrinkers in the system, and tries to count and consume objects related to the cgroup. In case of memory pressure, this behaves bad: I observe high system time and time spent in list_lru_count_one() for many processes

[PATCH] mm: Make count list_lru_one::nr_items lockless

2017-09-19 Thread Kirill Tkhai
During the reclaiming slab of a memcg, shrink_slab iterates over all registered shrinkers in the system, and tries to count and consume objects related to the cgroup. In case of memory pressure, this behaves bad: I observe high system time and time spent in list_lru_count_one() for many processes