Re: [PATCH] mm: Mark create_huge_pmd() inline to prevent build failure

2017-07-13 Thread Dan Williams
On Thu, Jul 13, 2017 at 12:04 AM, Geert Uytterhoeven wrote: > Hi Dan, > > On Thu, Jul 13, 2017 at 2:29 AM, Dan Williams > wrote: >> On Tue, Jul 11, 2017 at 11:57 PM, Geert Uytterhoeven >> wrote: >>> With gcc 4.1.2: >>> >>> mm/memory.o: In function `create_huge_pmd': >>> memory.c:(.text+

Re: [PATCH] mm: Mark create_huge_pmd() inline to prevent build failure

2017-07-13 Thread Geert Uytterhoeven
Hi Dan, On Thu, Jul 13, 2017 at 2:29 AM, Dan Williams wrote: > On Tue, Jul 11, 2017 at 11:57 PM, Geert Uytterhoeven > wrote: >> With gcc 4.1.2: >> >> mm/memory.o: In function `create_huge_pmd': >> memory.c:(.text+0x93e): undefined reference to >> `do_huge_pmd_anonymous_page' >> >> Conve

Re: [PATCH] mm: Mark create_huge_pmd() inline to prevent build failure

2017-07-12 Thread Dan Williams
On Wed, Jul 12, 2017 at 5:29 PM, Dan Williams wrote: > On Tue, Jul 11, 2017 at 11:57 PM, Geert Uytterhoeven > wrote: >> With gcc 4.1.2: >> >> mm/memory.o: In function `create_huge_pmd': >> memory.c:(.text+0x93e): undefined reference to >> `do_huge_pmd_anonymous_page' >> >> Converting tra

Re: [PATCH] mm: Mark create_huge_pmd() inline to prevent build failure

2017-07-12 Thread Dan Williams
On Tue, Jul 11, 2017 at 11:57 PM, Geert Uytterhoeven wrote: > With gcc 4.1.2: > > mm/memory.o: In function `create_huge_pmd': > memory.c:(.text+0x93e): undefined reference to > `do_huge_pmd_anonymous_page' > > Converting transparent_hugepage_enabled() from a macro to a static > inline fun

Re: [PATCH] mm: Mark create_huge_pmd() inline to prevent build failure

2017-07-12 Thread Arnd Bergmann
On Wed, Jul 12, 2017 at 9:37 AM, Geert Uytterhoeven wrote: > You did mention seeing it with mips-gcc-4.1 in the thread "[RFC] minimum gcc > version for kernel: raise to gcc-4.3 or 4.6?", but didn't provide any further > details. Finally I started seeing it myself for m68k ;-) Ah right, I misreme

Re: [PATCH] mm: Mark create_huge_pmd() inline to prevent build failure

2017-07-12 Thread Geert Uytterhoeven
Hi Arnd, On Wed, Jul 12, 2017 at 9:22 AM, Arnd Bergmann wrote: > On Wed, Jul 12, 2017 at 8:57 AM, Geert Uytterhoeven > wrote: >> With gcc 4.1.2: >> >> mm/memory.o: In function `create_huge_pmd': >> memory.c:(.text+0x93e): undefined reference to >> `do_huge_pmd_anonymous_page' >> >> Conv

Re: [PATCH] mm: Mark create_huge_pmd() inline to prevent build failure

2017-07-12 Thread Arnd Bergmann
On Wed, Jul 12, 2017 at 8:57 AM, Geert Uytterhoeven wrote: > > With gcc 4.1.2: > > mm/memory.o: In function `create_huge_pmd': > memory.c:(.text+0x93e): undefined reference to > `do_huge_pmd_anonymous_page' > > Converting transparent_hugepage_enabled() from a macro to a static > inline fu

[PATCH] mm: Mark create_huge_pmd() inline to prevent build failure

2017-07-11 Thread Geert Uytterhoeven
With gcc 4.1.2: mm/memory.o: In function `create_huge_pmd': memory.c:(.text+0x93e): undefined reference to `do_huge_pmd_anonymous_page' Converting transparent_hugepage_enabled() from a macro to a static inline function reduced the ability of the compiler to remove unused code. Fix this b