Re: [PATCH] mm: Use BUG_ON directly instead of a if condition followed by BUG

2018-09-10 Thread kbuild test robot
Hi zhong, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc3 next-20180910] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co

Re: [PATCH] mm: Use BUG_ON directly instead of a if condition followed by BUG

2018-09-10 Thread Michal Hocko
On Mon 10-09-18 22:03:17, zhong jiang wrote: > The if condition can be removed if we use BUG_ON directly. > The issule is detected with the help of Coccinelle. typo here Is this really worth changing? If anything I would really love to see the BUG_ON going away rather than make a cosmetic changes

[PATCH] mm: Use BUG_ON directly instead of a if condition followed by BUG

2018-09-10 Thread zhong jiang
The if condition can be removed if we use BUG_ON directly. The issule is detected with the help of Coccinelle. Signed-off-by: zhong jiang --- mm/memory_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 38d94b7..280b26c