Re: [PATCH] mm: Use octal not symbolic permissions

2018-03-28 Thread Joe Perches
On Wed, 2018-03-28 at 21:07 +0200, Michal Hocko wrote: > I wasn't aware that checkpatch can perform changes as well. Someone (probably me) should write some better documentation for checkpatch one day. The command-line --help output isn't obvious.

Re: [PATCH] mm: Use octal not symbolic permissions

2018-03-28 Thread Michal Hocko
On Wed 28-03-18 08:44:51, Joe Perches wrote: > On Wed, 2018-03-28 at 15:06 +0200, Michal Hocko wrote: > > On Mon 26-03-18 15:22:32, Joe Perches wrote: > > > mm/*.c files use symbolic and octal styles for permissions. > > > > > > Using octal and not symbolic permissions is preferred by many as more

Re: [PATCH] mm: Use octal not symbolic permissions

2018-03-28 Thread Joe Perches
On Wed, 2018-03-28 at 15:06 +0200, Michal Hocko wrote: > On Mon 26-03-18 15:22:32, Joe Perches wrote: > > mm/*.c files use symbolic and octal styles for permissions. > > > > Using octal and not symbolic permissions is preferred by many as more > > readable. > > > > https://lkml.org/lkml/2016/8/2/

Re: [PATCH] mm: Use octal not symbolic permissions

2018-03-28 Thread Michal Hocko
On Mon 26-03-18 15:22:32, Joe Perches wrote: > mm/*.c files use symbolic and octal styles for permissions. > > Using octal and not symbolic permissions is preferred by many as more > readable. > > https://lkml.org/lkml/2016/8/2/1945 > > Prefer the direct use of octal for permissions. > > Done u

Re: [PATCH] mm: Use octal not symbolic permissions

2018-03-26 Thread Joe Perches
On Mon, 2018-03-26 at 15:36 -0700, David Rientjes wrote: > extending some of these lines to be >80 characters also improves > the readability imo. Right. I have no personal objection to very occasionally using line lengths < ~100 chars instead of 80. AFAIK: neither does Linus. https://lkml.org

Re: [PATCH] mm: Use octal not symbolic permissions

2018-03-26 Thread Joe Perches
On Mon, 2018-03-26 at 15:41 -0700, Andrew Morton wrote: > On Mon, 26 Mar 2018 15:22:32 -0700 Joe Perches wrote: > > > mm/*.c files use symbolic and octal styles for permissions. > > > > Using octal and not symbolic permissions is preferred by many as more > > readable. > > > > https://lkml.org/

Re: [PATCH] mm: Use octal not symbolic permissions

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 15:22:32 -0700 Joe Perches wrote: > mm/*.c files use symbolic and octal styles for permissions. > > Using octal and not symbolic permissions is preferred by many as more > readable. > > https://lkml.org/lkml/2016/8/2/1945 > > Prefer the direct use of octal for permissions.

Re: [PATCH] mm: Use octal not symbolic permissions

2018-03-26 Thread David Rientjes
On Mon, 26 Mar 2018, Joe Perches wrote: > mm/*.c files use symbolic and octal styles for permissions. > > Using octal and not symbolic permissions is preferred by many as more > readable. > > https://lkml.org/lkml/2016/8/2/1945 > > Prefer the direct use of octal for permissions. > > Done using

[PATCH] mm: Use octal not symbolic permissions

2018-03-26 Thread Joe Perches
mm/*.c files use symbolic and octal styles for permissions. Using octal and not symbolic permissions is preferred by many as more readable. https://lkml.org/lkml/2016/8/2/1945 Prefer the direct use of octal for permissions. Done using $ scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inpl