Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-13 Thread Dave Hansen
On 12/13/2012 03:15 PM, Davidlohr Bueso wrote: > On Wed, 2012-12-12 at 20:49 -0800, Dave Hansen wrote: >> How is that possible? If NUMA nodes are defined by distances from CPUs >> to memory, how could a DIMM have more than a single distance to any >> given CPU? > > Can't this occur when interleav

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-13 Thread Davidlohr Bueso
On Wed, 2012-12-12 at 20:49 -0800, Dave Hansen wrote: > On 12/12/2012 06:03 PM, Davidlohr Bueso wrote: > > On Wed, 2012-12-12 at 17:48 -0800, Dave Hansen wrote: > >> But if we went and did it per-DIMM (showing which physical addresses and > >> NUMA nodes a DIMM maps to), wouldn't that be redundant

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-13 Thread KOSAKI Motohiro
(12/12/12 11:49 PM), Dave Hansen wrote: > On 12/12/2012 06:03 PM, Davidlohr Bueso wrote: >> On Wed, 2012-12-12 at 17:48 -0800, Dave Hansen wrote: >>> But if we went and did it per-DIMM (showing which physical addresses and >>> NUMA nodes a DIMM maps to), wouldn't that be redundant with this >>> pro

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-12 Thread Dave Hansen
On 12/12/2012 06:03 PM, Davidlohr Bueso wrote: > On Wed, 2012-12-12 at 17:48 -0800, Dave Hansen wrote: >> But if we went and did it per-DIMM (showing which physical addresses and >> NUMA nodes a DIMM maps to), wouldn't that be redundant with this >> proposed interface? > > If DIMMs overlap between

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-12 Thread Davidlohr Bueso
On Wed, 2012-12-12 at 17:48 -0800, Dave Hansen wrote: > On 12/12/2012 05:18 PM, Davidlohr Bueso wrote: > > On Fri, 2012-12-07 at 16:17 -0800, Dave Hansen wrote: > >> Seems like the better way to do this would be to expose the DIMMs > >> themselves in some way, and then map _those_ back to a node. >

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-12 Thread Dave Hansen
On 12/12/2012 05:18 PM, Davidlohr Bueso wrote: > On Fri, 2012-12-07 at 16:17 -0800, Dave Hansen wrote: >> Seems like the better way to do this would be to expose the DIMMs >> themselves in some way, and then map _those_ back to a node. > > Good point, and from a DIMM perspective, I agree, and will

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-12 Thread Davidlohr Bueso
On Fri, 2012-12-07 at 16:17 -0800, Dave Hansen wrote: > On 12/07/2012 03:51 PM, Andrew Morton wrote: > >> > +static ssize_t node_read_memrange(struct device *dev, > >> > + struct device_attribute *attr, char > >> > *buf) > >> > +{ > >> > +int nid = dev->id;

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-08 Thread Greg Kroah-Hartman
On Fri, Dec 07, 2012 at 02:34:56PM -0800, Davidlohr Bueso wrote: > This patch adds a new 'memrange' file that shows the starting and > ending physical addresses that are associated to a node. This is > useful for identifying specific DIMMs within the system. > > Signed-off-by: Davidlohr Bueso > -

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-07 Thread Dave Hansen
On 12/07/2012 03:51 PM, Andrew Morton wrote: >> > +static ssize_t node_read_memrange(struct device *dev, >> > +struct device_attribute *attr, char *buf) >> > +{ >> > + int nid = dev->id; >> > + unsigned long start_pfn = NODE_DATA(nid)->node_start_pfn; >> > + unsigned

Re: [PATCH] mm: add node physical memory range to sysfs

2012-12-07 Thread Andrew Morton
On Fri, 07 Dec 2012 14:34:56 -0800 Davidlohr Bueso wrote: > This patch adds a new 'memrange' file that shows the starting and > ending physical addresses that are associated to a node. This is > useful for identifying specific DIMMs within the system. I was going to bug you about docmentation, b

[PATCH] mm: add node physical memory range to sysfs

2012-12-07 Thread Davidlohr Bueso
This patch adds a new 'memrange' file that shows the starting and ending physical addresses that are associated to a node. This is useful for identifying specific DIMMs within the system. Signed-off-by: Davidlohr Bueso --- drivers/base/node.c | 15 +++ 1 file changed, 15 insertions(+