Re: [PATCH] mm: annotate refault stalls from swap_readpage

2019-10-11 Thread Andrew Morton
On Thu, 10 Oct 2019 15:17:47 -0400 Johannes Weiner wrote: > On Thu, Oct 10, 2019 at 08:21:34AM -0700, Minchan Kim wrote: > > From: Minchan Kim > > > > If block device supports rw_page operation, it doesn't submit bio > > so annotation in submit_bio for refault stall doesn't work. > > It happens

Re: [PATCH] mm: annotate refault stalls from swap_readpage

2019-10-11 Thread Shakeel Butt
On Thu, Oct 10, 2019 at 3:11 PM Minchan Kim wrote: > > On Thu, Oct 10, 2019 at 03:17:47PM -0400, Johannes Weiner wrote: > > On Thu, Oct 10, 2019 at 08:21:34AM -0700, Minchan Kim wrote: > > > From: Minchan Kim > > > > > > If block device supports rw_page operation, it doesn't submit bio > > > so a

Re: [PATCH] mm: annotate refault stalls from swap_readpage

2019-10-10 Thread Minchan Kim
On Thu, Oct 10, 2019 at 03:17:47PM -0400, Johannes Weiner wrote: > On Thu, Oct 10, 2019 at 08:21:34AM -0700, Minchan Kim wrote: > > From: Minchan Kim > > > > If block device supports rw_page operation, it doesn't submit bio > > so annotation in submit_bio for refault stall doesn't work. > > It ha

Re: [PATCH] mm: annotate refault stalls from swap_readpage

2019-10-10 Thread Johannes Weiner
On Thu, Oct 10, 2019 at 08:21:34AM -0700, Minchan Kim wrote: > From: Minchan Kim > > If block device supports rw_page operation, it doesn't submit bio > so annotation in submit_bio for refault stall doesn't work. > It happens with zram in android, especially swap read path which > could consume C

[PATCH] mm: annotate refault stalls from swap_readpage

2019-10-10 Thread Minchan Kim
From: Minchan Kim If block device supports rw_page operation, it doesn't submit bio so annotation in submit_bio for refault stall doesn't work. It happens with zram in android, especially swap read path which could consume CPU cycle for decompress. It is also a problem for zswap which uses fronts