Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread Minchan Kim
On Mon, Mar 08, 2021 at 07:58:11AM -0800, Minchan Kim wrote: > On Mon, Mar 08, 2021 at 04:42:43PM +0100, Michal Hocko wrote: > > On Mon 08-03-21 15:13:35, David Hildenbrand wrote: > > > On 08.03.21 15:11, Michal Hocko wrote: > > > > On Mon 08-03-21 14:22:12, David Hildenbrand wrote: > > > > > On 08

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread Minchan Kim
On Mon, Mar 08, 2021 at 05:21:47PM +0100, Michal Hocko wrote: > On Mon 08-03-21 07:58:11, Minchan Kim wrote: > [...] > > It's the dynamic debugging facility > > to enable only when admin want to use it. Otherwise, it's nop > > unless is't not enabled. Furthermore, it doesn't need to invent > > cust

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread Michal Hocko
On Mon 08-03-21 07:58:11, Minchan Kim wrote: [...] > It's the dynamic debugging facility > to enable only when admin want to use it. Otherwise, it's nop > unless is't not enabled. Furthermore, it doesn't need to invent > custom dump_page implementation(including dump_page_owner) by > chaning pr_deb

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread Minchan Kim
On Mon, Mar 08, 2021 at 04:42:43PM +0100, Michal Hocko wrote: > On Mon 08-03-21 15:13:35, David Hildenbrand wrote: > > On 08.03.21 15:11, Michal Hocko wrote: > > > On Mon 08-03-21 14:22:12, David Hildenbrand wrote: > > > > On 08.03.21 13:49, Michal Hocko wrote: > > > [...] > > > > > Earlier in the

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread Michal Hocko
On Mon 08-03-21 15:13:35, David Hildenbrand wrote: > On 08.03.21 15:11, Michal Hocko wrote: > > On Mon 08-03-21 14:22:12, David Hildenbrand wrote: > > > On 08.03.21 13:49, Michal Hocko wrote: > > [...] > > > > Earlier in the discussion I have suggested dynamic debugging facility. > > > > Documentat

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread David Hildenbrand
On 08.03.21 15:11, Michal Hocko wrote: On Mon 08-03-21 14:22:12, David Hildenbrand wrote: On 08.03.21 13:49, Michal Hocko wrote: [...] Earlier in the discussion I have suggested dynamic debugging facility. Documentation/admin-guide/dynamic-debug-howto.rst. Have you tried to look into that dire

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread Michal Hocko
On Mon 08-03-21 14:22:12, David Hildenbrand wrote: > On 08.03.21 13:49, Michal Hocko wrote: [...] > > Earlier in the discussion I have suggested dynamic debugging facility. > > Documentation/admin-guide/dynamic-debug-howto.rst. Have you tried to > > look into that direction? > > Did you see the pr

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread David Hildenbrand
On 08.03.21 13:49, Michal Hocko wrote: On Thu 04-03-21 10:22:51, Minchan Kim wrote: [...] How about this? diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 238d0fc232aa..489e557b9390 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8481,7 +8481,8 @@ static inline void dump_migrate_fail

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-08 Thread Michal Hocko
On Thu 04-03-21 10:22:51, Minchan Kim wrote: [...] > How about this? > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 238d0fc232aa..489e557b9390 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8481,7 +8481,8 @@ static inline void dump_migrate_failure_pages(struct > list_hea

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-04 Thread Minchan Kim
On Thu, Mar 04, 2021 at 10:11:35AM -0800, Minchan Kim wrote: > On Thu, Mar 04, 2021 at 06:23:09PM +0100, David Hildenbrand wrote: > > > > You want to debug something, so you try triggering it and capturing > > > > debug > > > > data. There are not that many alloc_contig_range() users such that thi

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-04 Thread Minchan Kim
On Thu, Mar 04, 2021 at 06:23:09PM +0100, David Hildenbrand wrote: > > > You want to debug something, so you try triggering it and capturing debug > > > data. There are not that many alloc_contig_range() users such that this > > > would really be an issue to isolate ... > > > > cma_alloc uses allo

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-04 Thread David Hildenbrand
You want to debug something, so you try triggering it and capturing debug data. There are not that many alloc_contig_range() users such that this would really be an issue to isolate ... cma_alloc uses alloc_contig_range and cma_alloc has lots of users. Even, it is expoerted by dmabuf so any user

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-04 Thread Minchan Kim
On Thu, Mar 04, 2021 at 05:28:32PM +0100, David Hildenbrand wrote: > On 04.03.21 17:23, Minchan Kim wrote: > > On Thu, Mar 04, 2021 at 05:10:52PM +0100, David Hildenbrand wrote: > > > On 04.03.21 17:01, Minchan Kim wrote: > > > > On Tue, Mar 02, 2021 at 09:23:49AM -0800, Minchan Kim wrote: > > > >

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-04 Thread David Hildenbrand
On 04.03.21 17:23, Minchan Kim wrote: On Thu, Mar 04, 2021 at 05:10:52PM +0100, David Hildenbrand wrote: On 04.03.21 17:01, Minchan Kim wrote: On Tue, Mar 02, 2021 at 09:23:49AM -0800, Minchan Kim wrote: On Fri, Feb 19, 2021 at 10:28:12AM +0100, Michal Hocko wrote: On Thu 18-02-21 08:19:50, M

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-04 Thread Minchan Kim
On Thu, Mar 04, 2021 at 05:10:52PM +0100, David Hildenbrand wrote: > On 04.03.21 17:01, Minchan Kim wrote: > > On Tue, Mar 02, 2021 at 09:23:49AM -0800, Minchan Kim wrote: > > > On Fri, Feb 19, 2021 at 10:28:12AM +0100, Michal Hocko wrote: > > > > On Thu 18-02-21 08:19:50, Minchan Kim wrote: > > >

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-04 Thread David Hildenbrand
On 04.03.21 17:01, Minchan Kim wrote: On Tue, Mar 02, 2021 at 09:23:49AM -0800, Minchan Kim wrote: On Fri, Feb 19, 2021 at 10:28:12AM +0100, Michal Hocko wrote: On Thu 18-02-21 08:19:50, Minchan Kim wrote: On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: On 18.02.21 10:35, M

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-04 Thread Minchan Kim
On Tue, Mar 02, 2021 at 09:23:49AM -0800, Minchan Kim wrote: > On Fri, Feb 19, 2021 at 10:28:12AM +0100, Michal Hocko wrote: > > On Thu 18-02-21 08:19:50, Minchan Kim wrote: > > > On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: > > > > On 18.02.21 10:35, Michal Hocko wrote: > > >

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-03-02 Thread Minchan Kim
On Fri, Feb 19, 2021 at 10:28:12AM +0100, Michal Hocko wrote: > On Thu 18-02-21 08:19:50, Minchan Kim wrote: > > On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: > > > On 18.02.21 10:35, Michal Hocko wrote: > > > > On Thu 18-02-21 10:02:43, David Hildenbrand wrote: > > > > > On 18

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-19 Thread David Hildenbrand
On 19.02.21 11:02, Michal Hocko wrote: On Fri 19-02-21 10:30:12, David Hildenbrand wrote: On 19.02.21 10:28, Michal Hocko wrote: On Thu 18-02-21 08:19:50, Minchan Kim wrote: On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: On 18.02.21 10:35, Michal Hocko wrote: On Thu 18-02

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-19 Thread Michal Hocko
On Fri 19-02-21 10:30:12, David Hildenbrand wrote: > On 19.02.21 10:28, Michal Hocko wrote: > > On Thu 18-02-21 08:19:50, Minchan Kim wrote: > > > On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: > > > > On 18.02.21 10:35, Michal Hocko wrote: > > > > > On Thu 18-02-21 10:02:43, Da

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-19 Thread David Hildenbrand
On 19.02.21 10:28, Michal Hocko wrote: On Thu 18-02-21 08:19:50, Minchan Kim wrote: On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: On 18.02.21 10:35, Michal Hocko wrote: On Thu 18-02-21 10:02:43, David Hildenbrand wrote: On 18.02.21 09:56, Michal Hocko wrote: On Wed 17-02

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-19 Thread Michal Hocko
On Thu 18-02-21 08:19:50, Minchan Kim wrote: > On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: > > On 18.02.21 10:35, Michal Hocko wrote: > > > On Thu 18-02-21 10:02:43, David Hildenbrand wrote: > > > > On 18.02.21 09:56, Michal Hocko wrote: > > > > > On Wed 17-02-21 08:36:03, Mi

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread David Hildenbrand
On 18.02.21 17:47, Minchan Kim wrote: On Thu, Feb 18, 2021 at 05:26:08PM +0100, David Hildenbrand wrote: On 18.02.21 17:19, Minchan Kim wrote: On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: On 18.02.21 10:35, Michal Hocko wrote: On Thu 18-02-21 10:02:43, David Hildenbrand

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread Minchan Kim
On Thu, Feb 18, 2021 at 05:26:08PM +0100, David Hildenbrand wrote: > On 18.02.21 17:19, Minchan Kim wrote: > > On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: > > > On 18.02.21 10:35, Michal Hocko wrote: > > > > On Thu 18-02-21 10:02:43, David Hildenbrand wrote: > > > > > On 18.0

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread David Hildenbrand
On 18.02.21 17:19, Minchan Kim wrote: On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: On 18.02.21 10:35, Michal Hocko wrote: On Thu 18-02-21 10:02:43, David Hildenbrand wrote: On 18.02.21 09:56, Michal Hocko wrote: On Wed 17-02-21 08:36:03, Minchan Kim wrote: alloc_contig_

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread Minchan Kim
On Thu, Feb 18, 2021 at 10:43:21AM +0100, David Hildenbrand wrote: > On 18.02.21 10:35, Michal Hocko wrote: > > On Thu 18-02-21 10:02:43, David Hildenbrand wrote: > > > On 18.02.21 09:56, Michal Hocko wrote: > > > > On Wed 17-02-21 08:36:03, Minchan Kim wrote: > > > > > alloc_contig_range is usuall

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread Minchan Kim
On Thu, Feb 18, 2021 at 09:56:18AM +0100, Michal Hocko wrote: > On Wed 17-02-21 08:36:03, Minchan Kim wrote: > > alloc_contig_range is usually used on cma area or movable zone. > > It's critical if the page migration fails on those areas so > > dump more debugging message like memory_hotplug unless

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread Michal Hocko
On Thu 18-02-21 10:43:21, David Hildenbrand wrote: > On 18.02.21 10:35, Michal Hocko wrote: > > On Thu 18-02-21 10:02:43, David Hildenbrand wrote: > > > On 18.02.21 09:56, Michal Hocko wrote: > > > > On Wed 17-02-21 08:36:03, Minchan Kim wrote: > > > > > alloc_contig_range is usually used on cma ar

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread David Hildenbrand
On 18.02.21 10:35, Michal Hocko wrote: On Thu 18-02-21 10:02:43, David Hildenbrand wrote: On 18.02.21 09:56, Michal Hocko wrote: On Wed 17-02-21 08:36:03, Minchan Kim wrote: alloc_contig_range is usually used on cma area or movable zone. It's critical if the page migration fails on those areas

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread Michal Hocko
On Thu 18-02-21 10:02:43, David Hildenbrand wrote: > On 18.02.21 09:56, Michal Hocko wrote: > > On Wed 17-02-21 08:36:03, Minchan Kim wrote: > > > alloc_contig_range is usually used on cma area or movable zone. > > > It's critical if the page migration fails on those areas so > > > dump more debugg

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread David Hildenbrand
On 18.02.21 09:56, Michal Hocko wrote: On Wed 17-02-21 08:36:03, Minchan Kim wrote: alloc_contig_range is usually used on cma area or movable zone. It's critical if the page migration fails on those areas so dump more debugging message like memory_hotplug unless user specifiy __GFP_NOWARN. I a

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-18 Thread Michal Hocko
On Wed 17-02-21 08:36:03, Minchan Kim wrote: > alloc_contig_range is usually used on cma area or movable zone. > It's critical if the page migration fails on those areas so > dump more debugging message like memory_hotplug unless user > specifiy __GFP_NOWARN. I agree with David that this has a pot

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-17 Thread Minchan Kim
On Wed, Feb 17, 2021 at 06:34:13PM +0100, David Hildenbrand wrote: > On 17.02.21 18:26, Minchan Kim wrote: > > On Wed, Feb 17, 2021 at 05:51:27PM +0100, David Hildenbrand wrote: > > > On 17.02.21 17:36, Minchan Kim wrote: > > > > alloc_contig_range is usually used on cma area or movable zone. > > >

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-17 Thread David Hildenbrand
On 17.02.21 18:26, Minchan Kim wrote: On Wed, Feb 17, 2021 at 05:51:27PM +0100, David Hildenbrand wrote: On 17.02.21 17:36, Minchan Kim wrote: alloc_contig_range is usually used on cma area or movable zone. It's critical if the page migration fails on those areas so dump more debugging message

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-17 Thread Minchan Kim
On Wed, Feb 17, 2021 at 05:51:27PM +0100, David Hildenbrand wrote: > On 17.02.21 17:36, Minchan Kim wrote: > > alloc_contig_range is usually used on cma area or movable zone. > > It's critical if the page migration fails on those areas so > > dump more debugging message like memory_hotplug unless u

Re: [PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-17 Thread David Hildenbrand
On 17.02.21 17:36, Minchan Kim wrote: alloc_contig_range is usually used on cma area or movable zone. It's critical if the page migration fails on those areas so dump more debugging message like memory_hotplug unless user specifiy __GFP_NOWARN. Signed-off-by: Minchan Kim --- mm/page_alloc.c |

[PATCH] mm: be more verbose for alloc_contig_range faliures

2021-02-17 Thread Minchan Kim
alloc_contig_range is usually used on cma area or movable zone. It's critical if the page migration fails on those areas so dump more debugging message like memory_hotplug unless user specifiy __GFP_NOWARN. Signed-off-by: Minchan Kim --- mm/page_alloc.c | 16 +++- 1 file changed, 15