Re: [PATCH] mm: bootmem: Check pfn_valid() before accessing struct page

2014-06-03 Thread Fleming, Matt
On 27 May 2014 19:45, Dave Hansen wrote: > > I don't think this is quite right. pfn_valid() tells us whether we have > a 'struct page' there or not. *BUT*, it does not tell us whether it is > RAM that we can actually address and than can be freed in to the buddy > allocator. > > I think

Re: [PATCH] mm: bootmem: Check pfn_valid() before accessing struct page

2014-06-03 Thread Fleming, Matt
On 27 May 2014 19:45, Dave Hansen dave.han...@intel.com wrote: I don't think this is quite right. pfn_valid() tells us whether we have a 'struct page' there or not. *BUT*, it does not tell us whether it is RAM that we can actually address and than can be freed in to the buddy allocator. I

Re: [PATCH] mm: bootmem: Check pfn_valid() before accessing struct page

2014-05-27 Thread Dave Hansen
On 05/27/2014 07:10 AM, Matt Fleming wrote: > We need to check that a pfn is valid before handing it to pfn_to_page() > since on low memory systems with CONFIG_HIGHMEM=n it's possible that a > pfn may not have a corresponding struct page. > > This is in fact the case for one of Alan's machines

[PATCH] mm: bootmem: Check pfn_valid() before accessing struct page

2014-05-27 Thread Matt Fleming
We need to check that a pfn is valid before handing it to pfn_to_page() since on low memory systems with CONFIG_HIGHMEM=n it's possible that a pfn may not have a corresponding struct page. This is in fact the case for one of Alan's machines where some of the EFI boot services pages live in

[PATCH] mm: bootmem: Check pfn_valid() before accessing struct page

2014-05-27 Thread Matt Fleming
We need to check that a pfn is valid before handing it to pfn_to_page() since on low memory systems with CONFIG_HIGHMEM=n it's possible that a pfn may not have a corresponding struct page. This is in fact the case for one of Alan's machines where some of the EFI boot services pages live in

Re: [PATCH] mm: bootmem: Check pfn_valid() before accessing struct page

2014-05-27 Thread Dave Hansen
On 05/27/2014 07:10 AM, Matt Fleming wrote: We need to check that a pfn is valid before handing it to pfn_to_page() since on low memory systems with CONFIG_HIGHMEM=n it's possible that a pfn may not have a corresponding struct page. This is in fact the case for one of Alan's machines where