Re: [PATCH] mm: compaction: some tracepoints should be defined only when CONFIG_COMPACTION is set

2019-03-12 Thread Yafang Shao
On Wed, Mar 13, 2019 at 12:44 AM Michal Hocko wrote: > > On Wed 13-03-19 00:29:57, Yafang Shao wrote: > > On Wed, Mar 13, 2019 at 12:18 AM Michal Hocko wrote: > > > > > > On Sat 02-03-19 12:38:58, Yafang Shao wrote: > > > > Only mm_compaction_isolate_{free, migrate}pages may be used when > > > >

Re: [PATCH] mm: compaction: some tracepoints should be defined only when CONFIG_COMPACTION is set

2019-03-12 Thread Michal Hocko
On Wed 13-03-19 00:29:57, Yafang Shao wrote: > On Wed, Mar 13, 2019 at 12:18 AM Michal Hocko wrote: > > > > On Sat 02-03-19 12:38:58, Yafang Shao wrote: > > > Only mm_compaction_isolate_{free, migrate}pages may be used when > > > CONFIG_COMPACTION is not set. > > > All others are used only when

Re: [PATCH] mm: compaction: some tracepoints should be defined only when CONFIG_COMPACTION is set

2019-03-12 Thread Yafang Shao
On Wed, Mar 13, 2019 at 12:18 AM Michal Hocko wrote: > > On Sat 02-03-19 12:38:58, Yafang Shao wrote: > > Only mm_compaction_isolate_{free, migrate}pages may be used when > > CONFIG_COMPACTION is not set. > > All others are used only when CONFIG_COMPACTION is set. > > Why is this an improvement?

Re: [PATCH] mm: compaction: some tracepoints should be defined only when CONFIG_COMPACTION is set

2019-03-12 Thread Michal Hocko
On Sat 02-03-19 12:38:58, Yafang Shao wrote: > Only mm_compaction_isolate_{free, migrate}pages may be used when > CONFIG_COMPACTION is not set. > All others are used only when CONFIG_COMPACTION is set. Why is this an improvement? > Signed-off-by: Yafang Shao > --- >

[PATCH] mm: compaction: some tracepoints should be defined only when CONFIG_COMPACTION is set

2019-03-01 Thread Yafang Shao
Only mm_compaction_isolate_{free, migrate}pages may be used when CONFIG_COMPACTION is not set. All others are used only when CONFIG_COMPACTION is set. Signed-off-by: Yafang Shao --- include/trace/events/compaction.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git