Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Mike Rapoport
On Wed, Aug 21, 2019 at 06:17:12PM +0200, Marc Gonzalez wrote: > On 21/08/2019 17:06, Mike Rapoport wrote: > > > Both pgtable_cache_init() and pgd_cache_init() are used to initialize kmem > > cache for page table allocations on several architectures that do not use > > PAGE_SIZE tables for one or

Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Thomas Gleixner
On Wed, 21 Aug 2019, Mike Rapoport wrote: > diff --git a/arch/x86/include/asm/pgtable_32.h > b/arch/x86/include/asm/pgtable_32.h > index b9b9f8a..0dca7f7 100644 > --- a/arch/x86/include/asm/pgtable_32.h > +++ b/arch/x86/include/asm/pgtable_32.h > @@ -29,7 +29,6 @@ extern pgd_t

Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Will Deacon
On Wed, Aug 21, 2019 at 07:01:59PM +0300, Mike Rapoport wrote: > On Wed, Aug 21, 2019 at 04:49:42PM +0100, Will Deacon wrote: > > On Wed, Aug 21, 2019 at 06:06:58PM +0300, Mike Rapoport wrote: > > > diff --git a/init/main.c b/init/main.c > > > index b90cb5f..2fa8038 100644 > > > --- a/init/main.c

Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Marc Gonzalez
On 21/08/2019 17:06, Mike Rapoport wrote: > Both pgtable_cache_init() and pgd_cache_init() are used to initialize kmem > cache for page table allocations on several architectures that do not use > PAGE_SIZE tables for one or more levels of the page table hierarchy. > > Most architectures do not

Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Mike Rapoport
On Wed, Aug 21, 2019 at 04:49:42PM +0100, Will Deacon wrote: > On Wed, Aug 21, 2019 at 06:06:58PM +0300, Mike Rapoport wrote: > > Both pgtable_cache_init() and pgd_cache_init() are used to initialize kmem > > cache for page table allocations on several architectures that do not use > > PAGE_SIZE

Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Will Deacon
On Wed, Aug 21, 2019 at 06:06:58PM +0300, Mike Rapoport wrote: > Both pgtable_cache_init() and pgd_cache_init() are used to initialize kmem > cache for page table allocations on several architectures that do not use > PAGE_SIZE tables for one or more levels of the page table hierarchy. > > Most

Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Mike Rapoport
On Wed, Aug 21, 2019 at 08:15:44AM -0700, Matthew Wilcox wrote: > On Wed, Aug 21, 2019 at 06:06:58PM +0300, Mike Rapoport wrote: > > +++ b/arch/alpha/include/asm/pgtable.h > > @@ -362,7 +362,6 @@ extern void paging_init(void); > > /* > > * No page table caches to initialise > > */ > >

Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Matthew Wilcox
On Wed, Aug 21, 2019 at 06:06:58PM +0300, Mike Rapoport wrote: > +++ b/arch/alpha/include/asm/pgtable.h > @@ -362,7 +362,6 @@ extern void paging_init(void); > /* > * No page table caches to initialise > */ > -#define pgtable_cache_init() do { } while (0) Delete the comment too? > +++

[PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init()

2019-08-21 Thread Mike Rapoport
Both pgtable_cache_init() and pgd_cache_init() are used to initialize kmem cache for page table allocations on several architectures that do not use PAGE_SIZE tables for one or more levels of the page table hierarchy. Most architectures do not implement these functions and use __week default NOP