Re: [PATCH] mm: convert some level-less printks to pr_*

2014-03-27 Thread Christoph Lameter
Would like to retracting the ack after seeing the other comments. Will ack after then issues have been fixed. On Wed, 26 Mar 2014, Christoph Lameter wrote: > On Wed, 26 Mar 2014, Mitchel Humpherys wrote: > > > printk is meant to be used with an associated log level. There are some > > instances o

Re: [PATCH] mm: convert some level-less printks to pr_*

2014-03-26 Thread Christoph Lameter
On Wed, 26 Mar 2014, Mitchel Humpherys wrote: > printk is meant to be used with an associated log level. There are some > instances of printk scattered around the mm code where the log level is > missing. Add a log level and adhere to suggestions by > scripts/checkpatch.pl by moving to the pr_* ma

Re: [PATCH] mm: convert some level-less printks to pr_*

2014-03-26 Thread Joe Perches
On Wed, 2014-03-26 at 16:49 -0700, Mitchel Humpherys wrote: > printk is meant to be used with an associated log level. There are some > instances of printk scattered around the mm code where the log level is > missing. Add a log level and adhere to suggestions by > scripts/checkpatch.pl by moving t

[PATCH] mm: convert some level-less printks to pr_*

2014-03-26 Thread Mitchel Humpherys
printk is meant to be used with an associated log level. There are some instances of printk scattered around the mm code where the log level is missing. Add a log level and adhere to suggestions by scripts/checkpatch.pl by moving to the pr_* macros. Signed-off-by: Mitchel Humpherys --- mm/bounce