Re: [PATCH] mm: fix direct reclaim writeback regression

2014-07-28 Thread Johannes Weiner
On Sat, Jul 26, 2014 at 04:15:25PM -0700, Hugh Dickins wrote: > On Sun, 27 Jul 2014, Vlastimil Babka wrote: > > On 07/26/2014 09:58 PM, Hugh Dickins wrote: > > > Yes, 3.16-rc1's 68711a746345 ("mm, migration: add destination page > > > freeing callback") has provided such a way to compaction: if mig

Re: [PATCH] mm: fix direct reclaim writeback regression

2014-07-28 Thread Johannes Weiner
On Sat, Jul 26, 2014 at 12:58:23PM -0700, Hugh Dickins wrote: > Shortly before 3.16-rc1, Dave Jones reported: > > WARNING: CPU: 3 PID: 19721 at fs/xfs/xfs_aops.c:971 > xfs_vm_writepage+0x5ce/0x630 [xfs]() > CPU: 3 PID: 19721 Comm: trinity-c61 Not tainted 3.15.0+ #3 > Call Trace: > [] xfs

Re: [PATCH] mm: fix direct reclaim writeback regression

2014-07-26 Thread Hugh Dickins
On Sun, 27 Jul 2014, Vlastimil Babka wrote: > On 07/26/2014 09:58 PM, Hugh Dickins wrote: > > Yes, 3.16-rc1's 68711a746345 ("mm, migration: add destination page > > freeing callback") has provided such a way to compaction: if migrating > > a SwapBacked page fails, its newpage may be put back on the

Re: [PATCH] mm: fix direct reclaim writeback regression

2014-07-26 Thread Vlastimil Babka
On 07/26/2014 09:58 PM, Hugh Dickins wrote: > Yes, 3.16-rc1's 68711a746345 ("mm, migration: add destination page > freeing callback") has provided such a way to compaction: if migrating > a SwapBacked page fails, its newpage may be put back on the list for > later use with PageSwapBacked still set,

[PATCH] mm: fix direct reclaim writeback regression

2014-07-26 Thread Hugh Dickins
Shortly before 3.16-rc1, Dave Jones reported: WARNING: CPU: 3 PID: 19721 at fs/xfs/xfs_aops.c:971 xfs_vm_writepage+0x5ce/0x630 [xfs]() CPU: 3 PID: 19721 Comm: trinity-c61 Not tainted 3.15.0+ #3 Call Trace: [] xfs_vm_writepage+0x5ce/0x630 [xfs] [] shrink_page_list+0x8f9/0xb90 [] shrink_