Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

Hi Shakeel, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.17-rc6 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

Hi Shakeel, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.17-rc6 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

On Wed, 23 May 2018 05:14:36 +0800 kbuild test robot wrote: > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on mmotm/master] > [also build test ERROR on v4.17-rc6 next-20180517] > [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

On Wed, 23 May 2018 05:14:36 +0800 kbuild test robot wrote: > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on mmotm/master] > [also build test ERROR on v4.17-rc6 next-20180517] > [if your patch is applied to the wrong git tree, please drop us a note to > help

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

Hi Shakeel, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.17-rc6 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

Hi Shakeel, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.17-rc6 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

On Mon, 21 May 2018, Andrew Morton wrote: > The patch seems depressingly complex. > > And a bit underdocumented... Maybe separate out the bits that rename refcount to alias_count? > > + refcount_t refcount; > > + int alias_count; > > The semantic meaning of these two? What locking protects

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

On Mon, 21 May 2018, Andrew Morton wrote: > The patch seems depressingly complex. > > And a bit underdocumented... Maybe separate out the bits that rename refcount to alias_count? > > + refcount_t refcount; > > + int alias_count; > > The semantic meaning of these two? What locking protects

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

On Mon, May 21, 2018 at 11:42 AM Andrew Morton wrote: > On Mon, 21 May 2018 10:41:16 -0700 Shakeel Butt wrote: > > The memcg kmem cache creation and deactivation (SLUB only) is > > asynchronous. If a root kmem cache is destroyed whose memcg cache

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

On Mon, May 21, 2018 at 11:42 AM Andrew Morton wrote: > On Mon, 21 May 2018 10:41:16 -0700 Shakeel Butt wrote: > > The memcg kmem cache creation and deactivation (SLUB only) is > > asynchronous. If a root kmem cache is destroyed whose memcg cache is in > > the process of creation or

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

On Mon, 21 May 2018 10:41:16 -0700 Shakeel Butt wrote: > The memcg kmem cache creation and deactivation (SLUB only) is > asynchronous. If a root kmem cache is destroyed whose memcg cache is in > the process of creation or deactivation, the kernel may crash. > > Example of

Re: [PATCH] mm: fix race between kmem_cache destroy, create and deactivate

On Mon, 21 May 2018 10:41:16 -0700 Shakeel Butt wrote: > The memcg kmem cache creation and deactivation (SLUB only) is > asynchronous. If a root kmem cache is destroyed whose memcg cache is in > the process of creation or deactivation, the kernel may crash. > > Example of one such crash: >

[PATCH] mm: fix race between kmem_cache destroy, create and deactivate

The memcg kmem cache creation and deactivation (SLUB only) is asynchronous. If a root kmem cache is destroyed whose memcg cache is in the process of creation or deactivation, the kernel may crash. Example of one such crash: general protection fault: [#1] SMP PTI CPU: 1 PID:

[PATCH] mm: fix race between kmem_cache destroy, create and deactivate

The memcg kmem cache creation and deactivation (SLUB only) is asynchronous. If a root kmem cache is destroyed whose memcg cache is in the process of creation or deactivation, the kernel may crash. Example of one such crash: general protection fault: [#1] SMP PTI CPU: 1 PID: