Re: [PATCH] mm: fix special swap entry handling on copy mm

2013-08-12 Thread Jerome Glisse
On Mon, Aug 12, 2013 at 9:46 PM, Naoya Horiguchi wrote: > On Mon, Aug 12, 2013 at 05:49:37PM -0400, Jerome Glisse wrote: >> On Mon, Aug 12, 2013 at 05:36:40PM -0400, Naoya Horiguchi wrote: >> > Hi Jerome, >> > >> > On Mon, Aug 12, 2013 at 11:43:24AM -0400, j.gli...@gmail.com wrote: >> > > From: Je

Re: [PATCH] mm: fix special swap entry handling on copy mm

2013-08-12 Thread Naoya Horiguchi
On Mon, Aug 12, 2013 at 05:49:37PM -0400, Jerome Glisse wrote: > On Mon, Aug 12, 2013 at 05:36:40PM -0400, Naoya Horiguchi wrote: > > Hi Jerome, > > > > On Mon, Aug 12, 2013 at 11:43:24AM -0400, j.gli...@gmail.com wrote: > > > From: Jerome Glisse > > > > > > Prior to this copy_one_pte will never

Re: [PATCH] mm: fix special swap entry handling on copy mm

2013-08-12 Thread Jerome Glisse
On Mon, Aug 12, 2013 at 05:36:40PM -0400, Naoya Horiguchi wrote: > Hi Jerome, > > On Mon, Aug 12, 2013 at 11:43:24AM -0400, j.gli...@gmail.com wrote: > > From: Jerome Glisse > > > > Prior to this copy_one_pte will never reach the special swap file > > handling code because swap_duplicate will re

Re: [PATCH] mm: fix special swap entry handling on copy mm

2013-08-12 Thread Naoya Horiguchi
Hi Jerome, On Mon, Aug 12, 2013 at 11:43:24AM -0400, j.gli...@gmail.com wrote: > From: Jerome Glisse > > Prior to this copy_one_pte will never reach the special swap file > handling code because swap_duplicate will return invalid value. > > Note this is not fatal so nothing bad ever happen beca

[PATCH] mm: fix special swap entry handling on copy mm

2013-08-12 Thread j . glisse
From: Jerome Glisse Prior to this copy_one_pte will never reach the special swap file handling code because swap_duplicate will return invalid value. Note this is not fatal so nothing bad ever happen because of that. Reason is that copy_pte_range would break of its loop and call add_swap_count_c