Re: [PATCH] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-11-01 Thread Yasuaki Ishimatsu
Hi Mel and Kosaki, Thank you for posting patches. I tested your patches. And following table shows time of onlining a memory section. Amount of memory| 128GB | 192GB | 256GB| linux-3.12-rc7 | 24.3 | 30.2 | 45.6 | Kosaki's first

Re: [PATCH] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-10-31 Thread KOSAKI Motohiro
Nit. I would like to add following hunk. This is just nit because moving reserve pageblock is extreme rare. if (block_migratetype == MIGRATE_RESERVE) { + found++; set_pageblock_migratetype(page, MIGRATE_MOVABLE);

Re: [PATCH] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-10-31 Thread Mel Gorman
On Wed, Oct 30, 2013 at 04:19:07PM -0400, KOSAKI Motohiro wrote: > >@@ -3926,11 +3929,11 @@ static void setup_zone_migrate_reserve(struct zone > >*zone) > > /* > > * Reserve blocks are generally in place to help high-order atomic > > * allocations that are short-lived. A min_free_kby

Re: [PATCH] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-10-30 Thread KOSAKI Motohiro
@@ -3926,11 +3929,11 @@ static void setup_zone_migrate_reserve(struct zone *zone) /* * Reserve blocks are generally in place to help high-order atomic * allocations that are short-lived. A min_free_kbytes value that -* would result in more than 2 reserve blocks f

Re: [PATCH] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-10-30 Thread KOSAKI Motohiro
(10/30/13 11:19 AM), Mel Gorman wrote: On Wed, Oct 23, 2013 at 05:01:32PM -0400, kosaki.motoh...@gmail.com wrote: From: KOSAKI Motohiro Yasuaki Ithimatsu reported memory hot-add spent more than 5 _hours_ on 9TB memory machine and we found out setup_zone_migrate_reserve spnet >90% time. The pr

Re: [PATCH] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-10-30 Thread Mel Gorman
On Wed, Oct 23, 2013 at 05:01:32PM -0400, kosaki.motoh...@gmail.com wrote: > From: KOSAKI Motohiro > > Yasuaki Ithimatsu reported memory hot-add spent more than 5 _hours_ > on 9TB memory machine and we found out setup_zone_migrate_reserve > spnet >90% time. > > The problem is, setup_zone_migrate

[PATCH] mm: get rid of unnecessary pageblock scanning in setup_zone_migrate_reserve

2013-10-23 Thread kosaki . motohiro
From: KOSAKI Motohiro Yasuaki Ithimatsu reported memory hot-add spent more than 5 _hours_ on 9TB memory machine and we found out setup_zone_migrate_reserve spnet >90% time. The problem is, setup_zone_migrate_reserve scan all pageblock unconditionally, but it is only necessary number of reserved