Re: [PATCH] mm: madvise: complete input validation before taking lock

2013-04-10 Thread KOSAKI Motohiro
(4/10/13 7:45 PM), Rasmus Villemoes wrote: > In madvise(), there doesn't seem to be any reason for taking the > ¤t->mm->mmap_sem before start and len_in have been > validated. Incidentally, this removes the need for the out: label. > > > Signed-off-by: Rasmus Villemoes Looks good. Acked-by: KO

[PATCH] mm: madvise: complete input validation before taking lock

2013-04-10 Thread Rasmus Villemoes
In madvise(), there doesn't seem to be any reason for taking the ¤t->mm->mmap_sem before start and len_in have been validated. Incidentally, this removes the need for the out: label. Signed-off-by: Rasmus Villemoes --- diff --git a/mm/madvise.c b/mm/madvise.c index c58c94b..d2ae668 100644 --- a

Re: [PATCH] mm: madvise: complete input validation before taking lock

2013-04-10 Thread David Rientjes
On Wed, 10 Apr 2013, Rasmus Villemoes wrote: > In madvise(), there doesn't seem to be any reason for taking the > ¤t->mm->mmap_sem before start and len_in have been > validated. Incidentally, this removes the need for the out: label. > > > Signed-off-by: Rasmus Villemoes Acked-by: David Rientj