Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-14 Thread Vlastimil Babka
On 08/13/2015 04:40 PM, Eric Dumazet wrote: On Thu, 2015-08-13 at 11:13 +0200, Vlastimil Babka wrote: Given that this apparently isn't the first case of this localhost issue, I wonder if network code should just clear skb->pfmemalloc during send (or maybe just send over localhost). That would b

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 11:13 +0200, Vlastimil Babka wrote: > Given that this apparently isn't the first case of this localhost issue, > I wonder if network code should just clear skb->pfmemalloc during send > (or maybe just send over localhost). That would be probably easier than > distinguish t

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread Mel Gorman
On Thu, Aug 13, 2015 at 10:58:54AM +0200, mho...@kernel.org wrote: > From: Michal Hocko > > The patch c48a11c7ad26 ("netvm: propagate page->pfmemalloc to skb") > added the checks for page->pfmemalloc to __skb_fill_page_desc(): > > if (page->pfmemalloc && !page->mapping) >

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread Michal Hocko
On Thu 13-08-15 11:13:04, Vlastimil Babka wrote: > On 08/13/2015 10:58 AM, mho...@kernel.org wrote: > >From: Michal Hocko > > > >The patch c48a11c7ad26 ("netvm: propagate page->pfmemalloc to skb") > >added the checks for page->pfmemalloc to __skb_fill_page_desc(): > > > > if (page->pfmemal

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread Vlastimil Babka
On 08/13/2015 10:58 AM, mho...@kernel.org wrote: From: Michal Hocko The patch c48a11c7ad26 ("netvm: propagate page->pfmemalloc to skb") added the checks for page->pfmemalloc to __skb_fill_page_desc(): if (page->pfmemalloc && !page->mapping) skb->pfmemalloc = true; It

[PATCH] mm: make page pfmemalloc check more robust

2015-08-13 Thread mhocko
From: Michal Hocko The patch c48a11c7ad26 ("netvm: propagate page->pfmemalloc to skb") added the checks for page->pfmemalloc to __skb_fill_page_desc(): if (page->pfmemalloc && !page->mapping) skb->pfmemalloc = true; It assumes page->mapping == NULL implies that page->pfm