Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-03-07 Thread Lars Persson
On 2/26/19 12:57 PM, Lars Persson wrote: On 2/26/19 11:07 AM, Vlastimil Babka wrote: On 2/26/19 9:40 AM, Lars Persson wrote: What about CC stable and a Fixes tag, would it be applicable here? Yes this is candidate for stable so let's add: Cc: I do not find a good candidate for a Fixes

Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-26 Thread Lars Persson
On 2/26/19 11:07 AM, Vlastimil Babka wrote: On 2/26/19 9:40 AM, Lars Persson wrote: What about CC stable and a Fixes tag, would it be applicable here? Yes this is candidate for stable so let's add: Cc: I do not find a good candidate for a Fixes tag. How bout a version range where the b

Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-26 Thread Vlastimil Babka
On 2/26/19 9:40 AM, Lars Persson wrote: >> What about CC stable and a Fixes tag, would it be applicable here? >> > > Yes this is candidate for stable so let's add: > Cc: > > I do not find a good candidate for a Fixes tag. How bout a version range where the bug needs to be fixed then?

Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-26 Thread Lars Persson
On Tue, Feb 26, 2019 at 10:23 AM Anshuman Khandual wrote: > On 02/19/2019 06:02 PM, Lars Persson wrote: > > Our MIPS 1004Kc SoCs were seeing random userspace crashes with SIGILL > > and SIGSEGV that could not be traced back to a userspace code > > bug. They had all the magic signs of an I/D cache

Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-26 Thread Anshuman Khandual
On 02/19/2019 06:02 PM, Lars Persson wrote: > Our MIPS 1004Kc SoCs were seeing random userspace crashes with SIGILL > and SIGSEGV that could not be traced back to a userspace code > bug. They had all the magic signs of an I/D cache coherency issue. > > Now recently we noticed that the /proc/sys

Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-26 Thread Lars Persson
On 2/25/19 4:07 PM, Vlastimil Babka wrote: On 2/19/19 1:32 PM, Lars Persson wrote: Our MIPS 1004Kc SoCs were seeing random userspace crashes with SIGILL and SIGSEGV that could not be traced back to a userspace code bug. They had all the magic signs of an I/D cache coherency issue. Now recentl

Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-25 Thread Vlastimil Babka
On 2/19/19 1:32 PM, Lars Persson wrote: > Our MIPS 1004Kc SoCs were seeing random userspace crashes with SIGILL > and SIGSEGV that could not be traced back to a userspace code > bug. They had all the magic signs of an I/D cache coherency issue. > > Now recently we noticed that the /proc/sys/vm/com

Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-21 Thread Paul Burton
Hi Lars, On Tue, Feb 19, 2019 at 01:32:12PM +0100, Lars Persson wrote: > Our MIPS 1004Kc SoCs were seeing random userspace crashes with SIGILL > and SIGSEGV that could not be traced back to a userspace code > bug. They had all the magic signs of an I/D cache coherency issue. > > Now recently we n

Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-21 Thread Mel Gorman
On Tue, Feb 19, 2019 at 01:32:12PM +0100, Lars Persson wrote: > Our MIPS 1004Kc SoCs were seeing random userspace crashes with SIGILL > and SIGSEGV that could not be traced back to a userspace code > bug. They had all the magic signs of an I/D cache coherency issue. > > Now recently we noticed tha

[PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-19 Thread Lars Persson
Our MIPS 1004Kc SoCs were seeing random userspace crashes with SIGILL and SIGSEGV that could not be traced back to a userspace code bug. They had all the magic signs of an I/D cache coherency issue. Now recently we noticed that the /proc/sys/vm/compact_memory interface was quite efficient at provo