Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-05-01 Thread Robin Holt
On Thu, Apr 18, 2013 at 02:52:31AM +0800, Xiao Guangrong wrote: > On 04/18/2013 02:45 AM, Robin Holt wrote: > > >>> For the v3.10 release, we should work on making this more > >>> correct and completely documented. > >> > >> Better document is always welcomed. > >> > >> Dou

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-17 Thread Simon Jeons
Hi Robin, On 04/16/2013 05:31 PM, Robin Holt wrote: On Tue, Apr 16, 2013 at 02:39:49PM +0800, Xiao Guangrong wrote: The commit 751efd8610d3 (mmu_notifier_unregister NULL Pointer deref and multiple ->release()) breaks the fix: 3ad3d901bbcfb15a5e4690e55350db0899095a68 (mm: mmu_notifier:

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-17 Thread Xiao Guangrong
On 04/18/2013 02:45 AM, Robin Holt wrote: >>> For the v3.10 release, we should work on making this more >>> correct and completely documented. >> >> Better document is always welcomed. >> >> Double call ->release is not bad, like i mentioned it in the changelog: >>

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-17 Thread Robin Holt
On Thu, Apr 18, 2013 at 02:41:31AM +0800, Xiao Guangrong wrote: > On 04/17/2013 10:10 PM, Robin Holt wrote: > > On Wed, Apr 17, 2013 at 10:55:26AM +0800, Xiao Guangrong wrote: > >> On 04/17/2013 02:08 AM, Robin Holt wrote: > >>> On Tue, Apr 16, 2013 at 09:07:20PM +0800, Xiao Guangrong wrote: >

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-17 Thread Xiao Guangrong
On 04/17/2013 10:10 PM, Robin Holt wrote: > On Wed, Apr 17, 2013 at 10:55:26AM +0800, Xiao Guangrong wrote: >> On 04/17/2013 02:08 AM, Robin Holt wrote: >>> On Tue, Apr 16, 2013 at 09:07:20PM +0800, Xiao Guangrong wrote: On 04/16/2013 07:43 PM, Robin Holt wrote: > Argh. Taking a step back

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-17 Thread Robin Holt
On Wed, Apr 17, 2013 at 10:55:26AM +0800, Xiao Guangrong wrote: > On 04/17/2013 02:08 AM, Robin Holt wrote: > > On Tue, Apr 16, 2013 at 09:07:20PM +0800, Xiao Guangrong wrote: > >> On 04/16/2013 07:43 PM, Robin Holt wrote: > >>> Argh. Taking a step back helped clear my head. > >>> > >>> For the -s

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-16 Thread Xiao Guangrong
On 04/17/2013 02:08 AM, Robin Holt wrote: > On Tue, Apr 16, 2013 at 09:07:20PM +0800, Xiao Guangrong wrote: >> On 04/16/2013 07:43 PM, Robin Holt wrote: >>> Argh. Taking a step back helped clear my head. >>> >>> For the -stable releases, I agree we should just go with your >>> revert-plus-hlist_de

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-16 Thread Robin Holt
On Tue, Apr 16, 2013 at 09:07:20PM +0800, Xiao Guangrong wrote: > On 04/16/2013 07:43 PM, Robin Holt wrote: > > Argh. Taking a step back helped clear my head. > > > > For the -stable releases, I agree we should just go with your > > revert-plus-hlist_del_init_rcu patch. I will give it a test > >

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-16 Thread Xiao Guangrong
On 04/16/2013 07:43 PM, Robin Holt wrote: > Argh. Taking a step back helped clear my head. > > For the -stable releases, I agree we should just go with your > revert-plus-hlist_del_init_rcu patch. I will give it a test > when I am in the office. Okay. Wait for your test report. Thank you in adv

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-16 Thread Robin Holt
Argh. Taking a step back helped clear my head. For the -stable releases, I agree we should just go with your revert-plus-hlist_del_init_rcu patch. I will give it a test when I am in the office. For the v3.10 release, we should work on making this more correct and completely documented. Robin

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-16 Thread Robin Holt
On Tue, Apr 16, 2013 at 06:26:36PM +0800, Xiao Guangrong wrote: > On 04/16/2013 05:31 PM, Robin Holt wrote: > > On Tue, Apr 16, 2013 at 02:39:49PM +0800, Xiao Guangrong wrote: > >> The commit 751efd8610d3 (mmu_notifier_unregister NULL Pointer deref > >> and multiple ->release()) breaks the fix: > >

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-16 Thread Xiao Guangrong
On 04/16/2013 05:31 PM, Robin Holt wrote: > On Tue, Apr 16, 2013 at 02:39:49PM +0800, Xiao Guangrong wrote: >> The commit 751efd8610d3 (mmu_notifier_unregister NULL Pointer deref >> and multiple ->release()) breaks the fix: >> 3ad3d901bbcfb15a5e4690e55350db0899095a68 >> (mm: mmu_notifier: f

Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-16 Thread Robin Holt
On Tue, Apr 16, 2013 at 02:39:49PM +0800, Xiao Guangrong wrote: > The commit 751efd8610d3 (mmu_notifier_unregister NULL Pointer deref > and multiple ->release()) breaks the fix: > 3ad3d901bbcfb15a5e4690e55350db0899095a68 > (mm: mmu_notifier: fix freed page still mapped in secondary MMU) Ca

[PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU

2013-04-16 Thread Xiao Guangrong
The commit 751efd8610d3 (mmu_notifier_unregister NULL Pointer deref and multiple ->release()) breaks the fix: 3ad3d901bbcfb15a5e4690e55350db0899095a68 (mm: mmu_notifier: fix freed page still mapped in secondary MMU) This patch reverts the commit and simply fix the bug spotted by that patch