Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-29 Thread Shi, Yang
On 4/22/2016 2:48 AM, Kirill A. Shutemov wrote: On Thu, Apr 21, 2016 at 03:56:07PM -0700, Shi, Yang wrote: On 4/21/2016 12:30 AM, Kirill A. Shutemov wrote: On Wed, Apr 20, 2016 at 02:00:11PM -0700, Shi, Yang wrote: Hi folks, I didn't realize pmd_* functions are protected by CONFIG_TRANSPARENT

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-22 Thread Kirill A. Shutemov
On Thu, Apr 21, 2016 at 03:56:07PM -0700, Shi, Yang wrote: > On 4/21/2016 12:30 AM, Kirill A. Shutemov wrote: > >On Wed, Apr 20, 2016 at 02:00:11PM -0700, Shi, Yang wrote: > >>Hi folks, > >> > >>I didn't realize pmd_* functions are protected by > >>CONFIG_TRANSPARENT_HUGEPAGE on the most architectu

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-21 Thread Shi, Yang
On 4/21/2016 2:15 AM, Hugh Dickins wrote: On Wed, 20 Apr 2016, Shi, Yang wrote: Hi folks, I didn't realize pmd_* functions are protected by CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this change. Before I fix all the affected architectures code, I want to check if you

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-21 Thread Shi, Yang
On 4/21/2016 12:30 AM, Kirill A. Shutemov wrote: On Wed, Apr 20, 2016 at 02:00:11PM -0700, Shi, Yang wrote: Hi folks, I didn't realize pmd_* functions are protected by CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this change. Before I fix all the affected architectures c

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-21 Thread Hugh Dickins
On Wed, 20 Apr 2016, Shi, Yang wrote: > Hi folks, > > I didn't realize pmd_* functions are protected by CONFIG_TRANSPARENT_HUGEPAGE > on the most architectures before I made this change. > > Before I fix all the affected architectures code, I want to check if you guys > think this change is wort

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-21 Thread Kirill A. Shutemov
On Wed, Apr 20, 2016 at 02:00:11PM -0700, Shi, Yang wrote: > Hi folks, > > I didn't realize pmd_* functions are protected by > CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this > change. > > Before I fix all the affected architectures code, I want to check if you > guys thi

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-20 Thread Shi, Yang
Hi folks, I didn't realize pmd_* functions are protected by CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this change. Before I fix all the affected architectures code, I want to check if you guys think this change is worth or not? Thanks, Yang On 4/20/2016 11:24 AM,

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-20 Thread kbuild test robot
Hi, [auto build test ERROR on v4.6-rc4] [also build test ERROR on next-20160420] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Yang-Shi/mm-move-huge_pmd_set_accessed-out-of-huge_memory-c/2016

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-20 Thread kbuild test robot
Hi, [auto build test ERROR on v4.6-rc4] [also build test ERROR on next-20160420] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Yang-Shi/mm-move-huge_pmd_set_accessed-out-of-huge_memory-c/2016

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-20 Thread kbuild test robot
Hi, [auto build test ERROR on v4.6-rc4] [also build test ERROR on next-20160420] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Yang-Shi/mm-move-huge_pmd_set_accessed-out-of-huge_memory-c/2016

[PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-20 Thread Yang Shi
huge_pmd_set_accessed is only called by __handle_mm_fault from memory.c, move the definition to memory.c and make it static like create_huge_pmd and wp_huge_pmd. Signed-off-by: Yang Shi --- include/linux/huge_mm.h | 4 mm/huge_memory.c| 23 --- mm/memory.c