Re: [PATCH] mm: no need to check return value of debugfs_create functions

2019-01-22 Thread Michal Hocko
On Tue 22-01-19 17:27:49, Greg KH wrote: > On Tue, Jan 22, 2019 at 05:07:01PM +0100, Michal Hocko wrote: [...] > > sounds like a poor design goal to me but not mine code to maintain so... > > The design goal was to make it as simple as possible to use, and that > includes "you do not care about

Re: [PATCH] mm: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 22, 2019 at 05:07:01PM +0100, Michal Hocko wrote: > On Tue 22-01-19 16:52:55, Greg KH wrote: > > On Tue, Jan 22, 2019 at 04:31:02PM +0100, Michal Hocko wrote: > > > On Tue 22-01-19 16:21:13, Greg KH wrote: > > > [...] > > > > diff --git a/mm/memblock.c b/mm/memblock.c > > > > index

Re: [PATCH] mm: no need to check return value of debugfs_create functions

2019-01-22 Thread Michal Hocko
On Tue 22-01-19 16:52:55, Greg KH wrote: > On Tue, Jan 22, 2019 at 04:31:02PM +0100, Michal Hocko wrote: > > On Tue 22-01-19 16:21:13, Greg KH wrote: > > [...] > > > diff --git a/mm/memblock.c b/mm/memblock.c > > > index 022d4cbb3618..18ee657fb918 100644 > > > --- a/mm/memblock.c > > > +++

Re: [PATCH] mm: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 22, 2019 at 04:31:02PM +0100, Michal Hocko wrote: > On Tue 22-01-19 16:21:13, Greg KH wrote: > [...] > > diff --git a/mm/memblock.c b/mm/memblock.c > > index 022d4cbb3618..18ee657fb918 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -1998,8 +1998,7 @@

Re: [PATCH] mm: no need to check return value of debugfs_create functions

2019-01-22 Thread Michal Hocko
On Tue 22-01-19 16:21:13, Greg KH wrote: [...] > diff --git a/mm/memblock.c b/mm/memblock.c > index 022d4cbb3618..18ee657fb918 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1998,8 +1998,7 @@ DEFINE_SHOW_ATTRIBUTE(memblock_debug); > static int __init memblock_init_debugfs(void) > { >

[PATCH] mm: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Michal Hocko Cc: Andrew Morton Cc: Vlastimil Babka Cc: David Rientjes Cc: Laura Abbott Cc: