Re: [PATCH] mm: prevent NR_ISOLATE_* stats from going negative

2017-04-20 Thread Michal Hocko
On Thu 20-04-17 12:24:25, Rabin Vincent wrote: > From: Rabin Vincent > > Commit 6afcf8ef0ca0 ("mm, compaction: fix NR_ISOLATED_* stats for pfn > based migration") moved the dec_node_page_state() call (along with the > page_is_file_cache() call) to after putback_lru_page(). But

Re: [PATCH] mm: prevent NR_ISOLATE_* stats from going negative

2017-04-20 Thread Michal Hocko
On Thu 20-04-17 12:24:25, Rabin Vincent wrote: > From: Rabin Vincent > > Commit 6afcf8ef0ca0 ("mm, compaction: fix NR_ISOLATED_* stats for pfn > based migration") moved the dec_node_page_state() call (along with the > page_is_file_cache() call) to after putback_lru_page(). But >

[PATCH] mm: prevent NR_ISOLATE_* stats from going negative

2017-04-20 Thread Rabin Vincent
From: Rabin Vincent Commit 6afcf8ef0ca0 ("mm, compaction: fix NR_ISOLATED_* stats for pfn based migration") moved the dec_node_page_state() call (along with the page_is_file_cache() call) to after putback_lru_page(). But page_is_file_cache() can change after putback_lru_page()

[PATCH] mm: prevent NR_ISOLATE_* stats from going negative

2017-04-20 Thread Rabin Vincent
From: Rabin Vincent Commit 6afcf8ef0ca0 ("mm, compaction: fix NR_ISOLATED_* stats for pfn based migration") moved the dec_node_page_state() call (along with the page_is_file_cache() call) to after putback_lru_page(). But page_is_file_cache() can change after putback_lru_page() is called, so it