Re: [PATCH] mm: save two stranding bit in gfp_mask

2018-05-23 Thread Michal Hocko
On Wed 23-05-18 16:08:28, kbuild test robot wrote: > Hi Shakeel, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on mmotm/master] > [also build test WARNING on v4.17-rc6] > [if your patch is applied to the wrong git tree, please drop us a note to > help im

Re: [PATCH] mm: save two stranding bit in gfp_mask

2018-05-23 Thread kbuild test robot
Hi Shakeel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mmotm/master] [also build test WARNING on v4.17-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commit

Re: [PATCH] mm: save two stranding bit in gfp_mask

2018-05-16 Thread Shakeel Butt
On Wed, May 16, 2018 at 1:41 PM Vlastimil Babka wrote: > On 05/16/2018 10:20 PM, Shakeel Butt wrote: > > ___GFP_COLD and ___GFP_OTHER_NODE were removed but their bits were > > stranded. Slide existing gfp masks to make those two bits available. > Well, there are already available for hypothetical

Re: [PATCH] mm: save two stranding bit in gfp_mask

2018-05-16 Thread Michal Hocko
On Wed 16-05-18 13:20:23, Shakeel Butt wrote: > ___GFP_COLD and ___GFP_OTHER_NODE were removed but their bits were > stranded. Slide existing gfp masks to make those two bits available. Could you make the patch a bit smaller smaller? E.g. diff --git a/include/linux/gfp.h b/include/linux/gfp.h ind

Re: [PATCH] mm: save two stranding bit in gfp_mask

2018-05-16 Thread Vlastimil Babka
On 05/16/2018 10:20 PM, Shakeel Butt wrote: > ___GFP_COLD and ___GFP_OTHER_NODE were removed but their bits were > stranded. Slide existing gfp masks to make those two bits available. Well, there are already available for hypothetical new flags. Is there anything that benefits from a smaller __GFP

[PATCH] mm: save two stranding bit in gfp_mask

2018-05-16 Thread Shakeel Butt
___GFP_COLD and ___GFP_OTHER_NODE were removed but their bits were stranded. Slide existing gfp masks to make those two bits available. Signed-off-by: Shakeel Butt --- include/linux/gfp.h | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --g