Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-16 Thread Yasuaki Ishimatsu
On Mon, 12 Oct 2015 09:37:17 +0800 Xishi Qiu wrote: > On 2015/10/9 23:41, Yasuaki Ishimatsu wrote: > > > > > On Thu, 8 Oct 2015 10:21:05 +0800 > > Xishi Qiu wrote: > > > >> If kernelcore was not specified, or the kernelcore size is zero > >> (required_movablecore >= totalpages), or the kerne

Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-13 Thread Tang Chen
On 10/14/2015 11:28 AM, Xishi Qiu wrote: On 2015/10/14 10:50, Tang Chen wrote: Hi, Qiu The patch seems OK to me. Only one little concern below. On 10/12/2015 09:37 AM, Xishi Qiu wrote: On 2015/10/9 23:41, Yasuaki Ishimatsu wrote: On Thu, 8 Oct 2015 10:21:05 +0800 Xishi Qiu wrote: If ke

Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-13 Thread Xishi Qiu
On 2015/10/14 10:50, Tang Chen wrote: > Hi, Qiu > > The patch seems OK to me. Only one little concern below. > > On 10/12/2015 09:37 AM, Xishi Qiu wrote: >> On 2015/10/9 23:41, Yasuaki Ishimatsu wrote: >> >>> On Thu, 8 Oct 2015 10:21:05 +0800 >>> Xishi Qiu wrote: >>> If kernelcore was not

Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-13 Thread Tang Chen
Hi, Qiu The patch seems OK to me. Only one little concern below. On 10/12/2015 09:37 AM, Xishi Qiu wrote: On 2015/10/9 23:41, Yasuaki Ishimatsu wrote: On Thu, 8 Oct 2015 10:21:05 +0800 Xishi Qiu wrote: If kernelcore was not specified, or the kernelcore size is zero (required_movablecore >=

Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-13 Thread David Rientjes
On Thu, 8 Oct 2015, Xishi Qiu wrote: > If kernelcore was not specified, or the kernelcore size is zero > (required_movablecore >= totalpages), or the kernelcore size is larger > than totalpages, there is no ZONE_MOVABLE. We should fill the zone > with both kernel memory and movable memory. > > Si

Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-11 Thread Xishi Qiu
On 2015/10/9 23:41, Yasuaki Ishimatsu wrote: > > On Thu, 8 Oct 2015 10:21:05 +0800 > Xishi Qiu wrote: > >> If kernelcore was not specified, or the kernelcore size is zero >> (required_movablecore >= totalpages), or the kernelcore size is larger > > Why does required_movablecore become larger t

Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-09 Thread Yasuaki Ishimatsu
On Thu, 8 Oct 2015 10:21:05 +0800 Xishi Qiu wrote: > If kernelcore was not specified, or the kernelcore size is zero > (required_movablecore >= totalpages), or the kernelcore size is larger Why does required_movablecore become larger than totalpages, when the kernelcore size is zero? I read the

[PATCH] mm: skip if required_kernelcore is larger than totalpages

2015-10-07 Thread Xishi Qiu
If kernelcore was not specified, or the kernelcore size is zero (required_movablecore >= totalpages), or the kernelcore size is larger than totalpages, there is no ZONE_MOVABLE. We should fill the zone with both kernel memory and movable memory. Signed-off-by: Xishi Qiu --- mm/page_alloc.c | 7 +