Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-02-16 Thread Faiyaz Mohammed
Hi Vlastimil, On 1/13/2021 9:35 PM, Vlastimil Babka wrote: > On 1/12/21 10:21 AM, Faiyaz Mohammed wrote: >> Reading the sys slab alloc_calls, free_calls returns the available object >> owners, but the size of this file is limited to PAGE_SIZE >> because of the limitation of sysfs attributes, it

Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-02-16 Thread Faiyaz Mohammed
Hi Matthew, On 1/12/2021 5:52 PM, Matthew Wilcox wrote: > On Tue, Jan 12, 2021 at 02:51:27PM +0530, Faiyaz Mohammed wrote: >> @@ -5180,6 +5187,7 @@ static int any_slab_objects(struct kmem_cache *s) >> >> struct slab_attribute { >> struct attribute attr; >> +struct bin_attribute

Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-01-24 Thread Faiyaz Mohammed
On 1/13/2021 9:35 PM, Vlastimil Babka wrote: > On 1/12/21 10:21 AM, Faiyaz Mohammed wrote: >> Reading the sys slab alloc_calls, free_calls returns the available object >> owners, but the size of this file is limited to PAGE_SIZE >> because of the limitation of sysfs attributes, it is returning

Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-01-13 Thread Vlastimil Babka
On 1/12/21 10:21 AM, Faiyaz Mohammed wrote: > Reading the sys slab alloc_calls, free_calls returns the available object > owners, but the size of this file is limited to PAGE_SIZE > because of the limitation of sysfs attributes, it is returning the > partial owner info, which is not sufficient to

Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-01-12 Thread Faiyaz Mohammed
On 1/12/2021 5:52 PM, Matthew Wilcox wrote: > On Tue, Jan 12, 2021 at 02:51:27PM +0530, Faiyaz Mohammed wrote: >> @@ -5180,6 +5187,7 @@ static int any_slab_objects(struct kmem_cache *s) >> >> struct slab_attribute { >> struct attribute attr; >> +struct bin_attribute bin_attr; >>

Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-01-12 Thread Matthew Wilcox
On Tue, Jan 12, 2021 at 02:51:27PM +0530, Faiyaz Mohammed wrote: > @@ -5180,6 +5187,7 @@ static int any_slab_objects(struct kmem_cache *s) > > struct slab_attribute { > struct attribute attr; > + struct bin_attribute bin_attr; > ssize_t (*show)(struct kmem_cache *s, char *buf);

[PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to bin attribute

2021-01-12 Thread Faiyaz Mohammed
Reading the sys slab alloc_calls, free_calls returns the available object owners, but the size of this file is limited to PAGE_SIZE because of the limitation of sysfs attributes, it is returning the partial owner info, which is not sufficient to debug/account the slab memory and alloc_calls output