Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-07 Thread Christopher Lameter
On Sun, 3 May 2020, Rafael Aquini wrote: > On Sat, May 02, 2020 at 11:16:30PM +, Christopher Lameter wrote: > > On Fri, 1 May 2020, Rafael Aquini wrote: > > > > > Sometimes it is desirable to override SLUB's debug facilities > > > default behavior upon stumbling on a cache or object error > >

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-03 Thread Rafael Aquini
On Sat, May 02, 2020 at 11:16:30PM +, Christopher Lameter wrote: > On Fri, 1 May 2020, Rafael Aquini wrote: > > > Sometimes it is desirable to override SLUB's debug facilities > > default behavior upon stumbling on a cache or object error > > and just stop the execution in order to grab a core

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-03 Thread Rafael Aquini
On Fri, May 01, 2020 at 07:17:24PM -0400, Qian Cai wrote: > > > > On May 1, 2020, at 5:54 PM, Rafael Aquini wrote: > > > > It seems like a good idea which also would required "adding things" > > elsewhere, but doesn't look mutually exclusive with the approach here. > > Also, what’s so special

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-02 Thread Christopher Lameter
On Fri, 1 May 2020, Rafael Aquini wrote: > Sometimes it is desirable to override SLUB's debug facilities > default behavior upon stumbling on a cache or object error > and just stop the execution in order to grab a coredump, at > the error-spotting time, instead of trying to fix the issue > and re

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-01 Thread Qian Cai
> On May 1, 2020, at 5:54 PM, Rafael Aquini wrote: > > It seems like a good idea which also would required "adding things" > elsewhere, but doesn't look mutually exclusive with the approach here. Also, what’s so special about these bad pages here that deserve a crash dump, but not other TAIN

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-01 Thread Qian Cai
> On May 1, 2020, at 5:54 PM, Rafael Aquini wrote: > > On Fri, May 01, 2020 at 05:29:19PM -0400, Qian Cai wrote: >> >> >>> On May 1, 2020, at 5:15 PM, Rafael Aquini wrote: >>> >>> Sometimes it is desirable to override SLUB's debug facilities >>> default behavior upon stumbling on a cache o

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-01 Thread Rafael Aquini
On Fri, May 01, 2020 at 05:29:19PM -0400, Qian Cai wrote: > > > > On May 1, 2020, at 5:15 PM, Rafael Aquini wrote: > > > > Sometimes it is desirable to override SLUB's debug facilities > > default behavior upon stumbling on a cache or object error > > and just stop the execution in order to gra

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-01 Thread Rafael Aquini
On Fri, May 01, 2020 at 02:37:51PM -0700, Andrew Morton wrote: > On Fri, 1 May 2020 17:15:40 -0400 Rafael Aquini wrote: > > > Sometimes it is desirable to override SLUB's debug facilities > > default behavior upon stumbling on a cache or object error > > and just stop the execution in order to g

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-01 Thread Andrew Morton
On Fri, 1 May 2020 17:15:40 -0400 Rafael Aquini wrote: > Sometimes it is desirable to override SLUB's debug facilities > default behavior upon stumbling on a cache or object error > and just stop the execution in order to grab a coredump, at > the error-spotting time, instead of trying to fix th

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-01 Thread Qian Cai
> On May 1, 2020, at 5:15 PM, Rafael Aquini wrote: > > Sometimes it is desirable to override SLUB's debug facilities > default behavior upon stumbling on a cache or object error > and just stop the execution in order to grab a coredump, at > the error-spotting time, instead of trying to fix th

[PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-01 Thread Rafael Aquini
Sometimes it is desirable to override SLUB's debug facilities default behavior upon stumbling on a cache or object error and just stop the execution in order to grab a coredump, at the error-spotting time, instead of trying to fix the issue and report in an attempt to keep the system rolling. This