Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-17 Thread Hugh Dickins
On Tue, 17 May 2016, Michal Hocko wrote: > On Mon 16-05-16 15:36:56, Andrew Morton wrote: > > On Mon, 16 May 2016 16:23:33 +0200 Michal Hocko wrote: > > > > > Andrew, I think that the following is more straightforward fix and > > > should be folded in to the patch which has introduced vmstat_refr

Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-17 Thread Michal Hocko
On Mon 16-05-16 15:36:56, Andrew Morton wrote: > On Mon, 16 May 2016 16:23:33 +0200 Michal Hocko wrote: > > > Andrew, I think that the following is more straightforward fix and > > should be folded in to the patch which has introduced vmstat_refresh. > > --- > > >From b8dd18fb7df040e1bfe61aadde1d

Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-16 Thread Andrew Morton
On Mon, 16 May 2016 16:23:33 +0200 Michal Hocko wrote: > Andrew, I think that the following is more straightforward fix and > should be folded in to the patch which has introduced vmstat_refresh. > --- > >From b8dd18fb7df040e1bfe61aadde1d903589de15e4 Mon Sep 17 00:00:00 2001 > From: Michal Hocko

Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-16 Thread Michal Hocko
Andrew, I think that the following is more straightforward fix and should be folded in to the patch which has introduced vmstat_refresh. --- >From b8dd18fb7df040e1bfe61aadde1d903589de15e4 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Mon, 16 May 2016 16:19:53 +0200 Subject: [PATCH] mmotm: mm-p

Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-16 Thread Christoph Lameter
On Mon, 16 May 2016, Michal Hocko wrote: > I agree with Christoph that vmstat_refresh is PROC_FS only so we should > fix it there. It is not like this would be generally reusable helper... > Why don't we just do: Looks good. Acked-by: Christoph Lameter > --- > diff --git a/mm/vmstat.c b/mm/vms

Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-16 Thread Michal Hocko
On Wed 11-05-16 16:54:55, Arnd Bergmann wrote: > In randconfig builds with sysfs, procfs and numa all disabled, > but SMP enabled, we now get a link error in the newly introduced > vmstat_refresh function: > > mm/built-in.o: In function `vmstat_refresh': > :(.text+0x15c78): undefined reference to

Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-16 Thread Michal Hocko
On Wed 11-05-16 10:32:11, Christoph Lameter wrote: > Subject: Do not build vmstat_refresh if there is no procfs support > > It makes no sense to build functionality into the kernel that > cannot be used and causes build issues. > > Signed-off-by: Christoph Lameter > > Index: linux/mm/vmstat.c >

Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-11 Thread Christoph Lameter
On Wed, 11 May 2016, Arnd Bergmann wrote: > In randconfig builds with sysfs, procfs and numa all disabled, > but SMP enabled, we now get a link error in the newly introduced > vmstat_refresh function: > > mm/built-in.o: In function `vmstat_refresh': Hmmm... vmstat_refresh should not be build if C

[PATCH] mm: unhide vmstat_text definition for CONFIG_SMP

2016-05-11 Thread Arnd Bergmann
In randconfig builds with sysfs, procfs and numa all disabled, but SMP enabled, we now get a link error in the newly introduced vmstat_refresh function: mm/built-in.o: In function `vmstat_refresh': :(.text+0x15c78): undefined reference to `vmstat_text' This modifes the already elaborate #ifdef to