Re: [PATCH] mm: use srcu for shrinkers

2015-06-17 Thread Davidlohr Bueso
On Wed, 2015-06-17 at 09:47 +0200, Michal Hocko wrote: > On the other hand using srcu is a neat idea. Shrinkers only need the > existence guarantee when racing with unregister. Register even shouldn't > be that interesting because such a shrinker wouldn't have much to > shrink anyway so we can safe

Re: [PATCH] mm: use srcu for shrinkers

2015-06-17 Thread Michal Hocko
On Mon 15-06-15 13:03:22, Davidlohr Bueso wrote: > The shrinker_rwsem is a global lock that protects the shrinker_list, > serializing a shrinking call with register/unregistering the shrinker > itself. As such, this lock is taken mostly for reading. In the unlikely > case that the the list is being

[PATCH] mm: use srcu for shrinkers

2015-06-15 Thread Davidlohr Bueso
The shrinker_rwsem is a global lock that protects the shrinker_list, serializing a shrinking call with register/unregistering the shrinker itself. As such, this lock is taken mostly for reading. In the unlikely case that the the list is being modified, we simply return indicating we want to iterate