Re: [PATCH] mm: vmscan: count slab shrinking results after each shrink_slab()

2015-10-20 Thread Vladimir Davydov
On Tue, Oct 20, 2015 at 09:56:06AM -0400, Johannes Weiner wrote: > On Tue, Oct 20, 2015 at 03:19:20PM +0300, Vladimir Davydov wrote: > > On Mon, Oct 19, 2015 at 02:13:35PM -0400, Johannes Weiner wrote: > > > cb731d6 ("vmscan: per memory cgroup slab shrinkers") sought to > > > optimize accumulating

Re: [PATCH] mm: vmscan: count slab shrinking results after each shrink_slab()

2015-10-20 Thread Johannes Weiner
On Tue, Oct 20, 2015 at 03:19:20PM +0300, Vladimir Davydov wrote: > On Mon, Oct 19, 2015 at 02:13:35PM -0400, Johannes Weiner wrote: > > cb731d6 ("vmscan: per memory cgroup slab shrinkers") sought to > > optimize accumulating slab reclaim results in sc->nr_reclaimed only > > once per zone, but the

Re: [PATCH] mm: vmscan: count slab shrinking results after each shrink_slab()

2015-10-20 Thread Vladimir Davydov
On Mon, Oct 19, 2015 at 02:13:35PM -0400, Johannes Weiner wrote: > cb731d6 ("vmscan: per memory cgroup slab shrinkers") sought to > optimize accumulating slab reclaim results in sc->nr_reclaimed only > once per zone, but the memcg hierarchy walk itself uses > sc->nr_reclaimed as an exit condition.

[PATCH] mm: vmscan: count slab shrinking results after each shrink_slab()

2015-10-19 Thread Johannes Weiner
cb731d6 ("vmscan: per memory cgroup slab shrinkers") sought to optimize accumulating slab reclaim results in sc->nr_reclaimed only once per zone, but the memcg hierarchy walk itself uses sc->nr_reclaimed as an exit condition. This can lead to overreclaim. Signed-off-by: Johannes Weiner --- mm/vm