Re: [PATCH] mm: vmscan: fix not scanning anonymous pages when detecting file refaults

2019-06-28 Thread Minchan Kim
On Fri, Jun 28, 2019 at 10:22:52AM -0400, Johannes Weiner wrote: > Hi Minchan, > > On Fri, Jun 28, 2019 at 03:51:38PM +0900, Minchan Kim wrote: > > On Thu, Jun 27, 2019 at 02:41:23PM -0400, Johannes Weiner wrote: > > > On Wed, Jun 19, 2019 at 04:08:35PM +0800, Kuo-Hsin Yang wrote: > > > > Fixes: 2

Re: [PATCH] mm: vmscan: fix not scanning anonymous pages when detecting file refaults

2019-06-28 Thread Johannes Weiner
Hi Minchan, On Fri, Jun 28, 2019 at 03:51:38PM +0900, Minchan Kim wrote: > On Thu, Jun 27, 2019 at 02:41:23PM -0400, Johannes Weiner wrote: > > On Wed, Jun 19, 2019 at 04:08:35PM +0800, Kuo-Hsin Yang wrote: > > > Fixes: 2a2e48854d70 ("mm: vmscan: fix IO/refault regression in cache > > > workingse

Re: [PATCH] mm: vmscan: fix not scanning anonymous pages when detecting file refaults

2019-06-28 Thread Vovo Yang
On Fri, Jun 28, 2019 at 03:51:38PM +0900, Minchan Kim wrote: > Hi Johannes, > > On Thu, Jun 27, 2019 at 02:41:23PM -0400, Johannes Weiner wrote: > > > > Acked-by: Johannes Weiner > > > > Your change makes sense - we should indeed not force cache trimming > > only while the page cache is experie

Re: [PATCH] mm: vmscan: fix not scanning anonymous pages when detecting file refaults

2019-06-27 Thread Minchan Kim
Hi Kuo-Hsin, On Wed, Jun 19, 2019 at 04:08:35PM +0800, Kuo-Hsin Yang wrote: > When file refaults are detected and there are many inactive file pages, > the system never reclaim anonymous pages, the file pages are dropped > aggressively when there are still a lot of cold anonymous pages and > syste

Re: [PATCH] mm: vmscan: fix not scanning anonymous pages when detecting file refaults

2019-06-27 Thread Minchan Kim
Hi Johannes, On Thu, Jun 27, 2019 at 02:41:23PM -0400, Johannes Weiner wrote: > On Wed, Jun 19, 2019 at 04:08:35PM +0800, Kuo-Hsin Yang wrote: > > When file refaults are detected and there are many inactive file pages, > > the system never reclaim anonymous pages, the file pages are dropped > > ag

Re: [PATCH] mm: vmscan: fix not scanning anonymous pages when detecting file refaults

2019-06-27 Thread Johannes Weiner
On Wed, Jun 19, 2019 at 04:08:35PM +0800, Kuo-Hsin Yang wrote: > When file refaults are detected and there are many inactive file pages, > the system never reclaim anonymous pages, the file pages are dropped > aggressively when there are still a lot of cold anonymous pages and > system thrashes. Th

Re: [PATCH] mm: vmscan: fix not scanning anonymous pages when detecting file refaults

2019-06-26 Thread Andrew Morton
Could we please get some review of this one? Johannes, it supposedly fixes your patch? I added cc:stable to this. Agreeable? From: Kuo-Hsin Yang Subject: mm: vmscan: fix not scanning anonymous pages when detecting file refaults When file refaults are detected and there are many inactive fi

[PATCH] mm: vmscan: fix not scanning anonymous pages when detecting file refaults

2019-06-19 Thread Kuo-Hsin Yang
When file refaults are detected and there are many inactive file pages, the system never reclaim anonymous pages, the file pages are dropped aggressively when there are still a lot of cold anonymous pages and system thrashes. This issue impacts the performance of applications with large executable,