Re: [PATCH] mm:kswapd: clean up the kswapd

2014-06-23 Thread Chen Yucong
ke of it. It's not any > easier to understand as a result of the modification and does not appear > to be a preparation for a follow-on patch that addresses a bug. > Anyway, there are some palaces that still need to be cleaned in `kswapd'. thx! cyc Subject: [PATCH] mm:k

Re: [PATCH] mm:kswapd: clean up the kswapd

2014-06-23 Thread Mel Gorman
On Mon, Jun 23, 2014 at 01:14:54PM +0800, Chen Yucong wrote: > According to the commit 215ddd66 (mm: vmscan: only read new_classzone_idx from > pgdat when reclaiming successfully) and the commit d2ebd0f6b (kswapd: avoid > unnecessary rebalance after an unsuccessful balancing), we can use a boolean

Re: [PATCH] mm:kswapd: clean up the kswapd

2014-06-23 Thread Chen Yucong
of the modification and does not appear to be a preparation for a follow-on patch that addresses a bug. Anyway, there are some palaces that still need to be cleaned in `kswapd'. thx! cyc Subject: [PATCH] mm:kswapd: clean up the kswapd The type of variables(order, new_order, and balanced_order

Re: [PATCH] mm:kswapd: clean up the kswapd

2014-06-23 Thread Mel Gorman
On Mon, Jun 23, 2014 at 01:14:54PM +0800, Chen Yucong wrote: According to the commit 215ddd66 (mm: vmscan: only read new_classzone_idx from pgdat when reclaiming successfully) and the commit d2ebd0f6b (kswapd: avoid unnecessary rebalance after an unsuccessful balancing), we can use a boolean

[PATCH] mm:kswapd: clean up the kswapd

2014-06-22 Thread Chen Yucong
According to the commit 215ddd66 (mm: vmscan: only read new_classzone_idx from pgdat when reclaiming successfully) and the commit d2ebd0f6b (kswapd: avoid unnecessary rebalance after an unsuccessful balancing), we can use a boolean variable for replace balanced_* variables, which makes the kswapd

[PATCH] mm:kswapd: clean up the kswapd

2014-06-22 Thread Chen Yucong
According to the commit 215ddd66 (mm: vmscan: only read new_classzone_idx from pgdat when reclaiming successfully) and the commit d2ebd0f6b (kswapd: avoid unnecessary rebalance after an unsuccessful balancing), we can use a boolean variable for replace balanced_* variables, which makes the kswapd