Re: [PATCH] mmc: fix mmc dma operation

2019-10-21 Thread Nan Li
在 2019/10/21 17:17, Jerome Brunet 写道: > On Mon 21 Oct 2019 at 09:57, Neil Armstrong wrote: > >> Hi, >> >> Thanks for the fix. >> >> First, you should add "mmc: meson-gx:" in the subject. >> >> On 21/10/2019 07:59, Jianxin Pan wrote: >>> From: Nan Li >>> >>> In MMC dma transfer, the region request

Re: [PATCH] mmc: fix mmc dma operation

2019-10-21 Thread Jerome Brunet
On Mon 21 Oct 2019 at 16:48, Ulf Hansson wrote: > On Mon, 21 Oct 2019 at 11:17, Jerome Brunet wrote: >> >> >> On Mon 21 Oct 2019 at 09:57, Neil Armstrong wrote: >> >> > Hi, >> > >> > Thanks for the fix. >> > >> > First, you should add "mmc: meson-gx:" in the subject. >> > >> > On 21/10/2019 0

Re: [PATCH] mmc: fix mmc dma operation

2019-10-21 Thread Ulf Hansson
On Mon, 21 Oct 2019 at 11:17, Jerome Brunet wrote: > > > On Mon 21 Oct 2019 at 09:57, Neil Armstrong wrote: > > > Hi, > > > > Thanks for the fix. > > > > First, you should add "mmc: meson-gx:" in the subject. > > > > On 21/10/2019 07:59, Jianxin Pan wrote: > >> From: Nan Li > >> > >> In MMC dma

Re: [PATCH] mmc: fix mmc dma operation

2019-10-21 Thread Jerome Brunet
On Mon 21 Oct 2019 at 09:57, Neil Armstrong wrote: > Hi, > > Thanks for the fix. > > First, you should add "mmc: meson-gx:" in the subject. > > On 21/10/2019 07:59, Jianxin Pan wrote: >> From: Nan Li >> >> In MMC dma transfer, the region requested by dma_map_sg() may be released >> by dma_unm

Re: [PATCH] mmc: fix mmc dma operation

2019-10-21 Thread Jianxin Pan
Hi Neil, Thanks for the review, I will update the subject and commit message in the next version. On 2019/10/21 15:57, Neil Armstrong wrote: > Hi, > > Thanks for the fix. > > First, you should add "mmc: meson-gx:" in the subject. > > On 21/10/2019 07:59, Jianxin Pan wrote: >> From: Nan Li >>

Re: [PATCH] mmc: fix mmc dma operation

2019-10-21 Thread Neil Armstrong
Hi, Thanks for the fix. First, you should add "mmc: meson-gx:" in the subject. On 21/10/2019 07:59, Jianxin Pan wrote: > From: Nan Li > > In MMC dma transfer, the region requested by dma_map_sg() may be released > by dma_unmap_sg() before the transfer is completed. > > Put the unmap operation

[PATCH] mmc: fix mmc dma operation

2019-10-20 Thread Jianxin Pan
From: Nan Li In MMC dma transfer, the region requested by dma_map_sg() may be released by dma_unmap_sg() before the transfer is completed. Put the unmap operation in front of mmc_request_done() to avoid this. Signed-off-by: Nan Li Signed-off-by: Jianxin Pan --- drivers/mmc/host/meson-gx-mmc.