Re: [PATCH] mmc: sdhci-cadence: fix logically and structurally dead code

2018-04-19 Thread Gustavo A. R. Silva
I got it. I'll send v2 shortly. Thanks for the feedback, Masahiro. -- Gustavo On 04/19/2018 10:42 AM, Masahiro Yamada wrote: Hi. 2018-04-19 22:53 GMT+09:00 Gustavo A. R. Silva : Currently, the code block inside the for loop will never execute more than once, because the function returns in

Re: [PATCH] mmc: sdhci-cadence: fix logically and structurally dead code

2018-04-19 Thread Masahiro Yamada
Hi. 2018-04-19 22:53 GMT+09:00 Gustavo A. R. Silva : > Currently, the code block inside the for loop will never execute > more than once, because the function returns inmediately after > the first iteration, hence the execution of the code at the second > iteration is structurally dead and, code

[PATCH] mmc: sdhci-cadence: fix logically and structurally dead code

2018-04-19 Thread Gustavo A. R. Silva
Currently, the code block inside the for loop will never execute more than once, because the function returns inmediately after the first iteration, hence the execution of the code at the second iteration is structurally dead and, code at line 281: return 0; is never reached. Based on the code com