Re: [PATCH] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-20 Thread Georgi Djakov
On 03/19/2015 07:55 PM, Bjorn Andersson wrote: > On Thu, Mar 19, 2015 at 9:21 AM, Georgi Djakov > wrote: > [..] >>> Does the 8916 board you have work without bumping the >>> regulator_set_load() (previously regulator_set_optimum_mode())? None >>> of my 8974 boards work reliably without it. >> >>

Re: [PATCH] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-19 Thread Bjorn Andersson
On Thu, Mar 19, 2015 at 9:21 AM, Georgi Djakov wrote: [..] >> Does the 8916 board you have work without bumping the >> regulator_set_load() (previously regulator_set_optimum_mode())? None >> of my 8974 boards work reliably without it. > > My 8916 board seems to be working fine with this, at least

Re: [PATCH] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-19 Thread Georgi Djakov
Hi Bjorn, Thanks for taking a look. On 03/19/2015 05:36 PM, Bjorn Andersson wrote: > On Thu, Mar 19, 2015 at 5:55 AM, Georgi Djakov > wrote: > [..] > >> @@ -516,6 +527,22 @@ static int sdhci_msm_probe(struct platform_device *pdev) >> host_version, ((host_version & SDHCI_VENDOR_V

Re: [PATCH] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-19 Thread Bjorn Andersson
On Thu, Mar 19, 2015 at 5:55 AM, Georgi Djakov wrote: [..] > @@ -516,6 +527,22 @@ static int sdhci_msm_probe(struct platform_device *pdev) > host_version, ((host_version & SDHCI_VENDOR_VER_MASK) >> >SDHCI_VENDOR_VER_SHIFT)); > > + core_version

[PATCH] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-19 Thread Georgi Djakov
Some versions of this controller do not advertise their 3.0v and 8bit bus-width support capabilities. It is required to explicitly set these capabilities for the specific controller versions. Signed-off-by: Georgi Djakov --- Tested on msm8916-mtp board. drivers/mmc/host/sdhci-msm.c | 29 +