Re: [PATCH] modpost: Fix ressource leak in read_dump()

2014-04-22 Thread Rusty Russell
Michal Marek writes: > On 2014-04-06 02:05, Andi Kleen wrote: >> On Sun, Apr 06, 2014 at 12:36:49AM +0200, Christian Engelmayer wrote: >>> Function read_dump() memory maps the input via grab_file(), but fails to >>> call >>> the corresponding unmap function. Add the missing call to release_file(

Re: [PATCH] modpost: Fix ressource leak in read_dump()

2014-04-08 Thread Michal Marek
On 2014-04-06 02:05, Andi Kleen wrote: > On Sun, Apr 06, 2014 at 12:36:49AM +0200, Christian Engelmayer wrote: >> Function read_dump() memory maps the input via grab_file(), but fails to call >> the corresponding unmap function. Add the missing call to release_file(). >> Detected by Coverity: CID 1

Re: [PATCH] modpost: Fix ressource leak in read_dump()

2014-04-05 Thread Andi Kleen
On Sun, Apr 06, 2014 at 12:36:49AM +0200, Christian Engelmayer wrote: > Function read_dump() memory maps the input via grab_file(), but fails to call > the corresponding unmap function. Add the missing call to release_file(). > Detected by Coverity: CID 1192419 It doesn't matter at all. All memory

[PATCH] modpost: Fix ressource leak in read_dump()

2014-04-05 Thread Christian Engelmayer
Function read_dump() memory maps the input via grab_file(), but fails to call the corresponding unmap function. Add the missing call to release_file(). Detected by Coverity: CID 1192419 Signed-off-by: Christian Engelmayer --- Compile tested - Applies against v3.14 as well as linux-next. --- scri