Re: [PATCH] module: Annotate nested sleep in resolve_symbol()

2015-02-10 Thread Rusty Russell
Dave Jones writes: > On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote: > > On which, we should probably do this. > > > > --- > > Subject: module: Replace over-engineered nested sleep > > > > Since the introduction of the nested sleep warning; we've established > > that the

Re: [PATCH] module: Annotate nested sleep in resolve_symbol()

2015-02-10 Thread Dave Jones
On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote: > On which, we should probably do this. > > --- > Subject: module: Replace over-engineered nested sleep > > Since the introduction of the nested sleep warning; we've established > that the occasional sleep inside a

Re: [PATCH] module: Annotate nested sleep in resolve_symbol()

2015-02-10 Thread Peter Zijlstra
On which, we should probably do this. --- Subject: module: Replace over-engineered nested sleep Since the introduction of the nested sleep warning; we've established that the occasional sleep inside a wait_event() is fine. wait_event() loops are invariant wrt. spurious wakeups, and the

[PATCH] module: Annotate nested sleep in resolve_symbol()

2015-02-10 Thread Peter Zijlstra
Because wait_event() loops are safe vs spurious wakeups we can allow the occasional sleep -- which ends up being very similar. Cc: Rusty Russell Reported-by: Dave Jones Signed-off-by: Peter Zijlstra (Intel) --- kernel/module.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH] module: Annotate nested sleep in resolve_symbol()

2015-02-10 Thread Dave Jones
On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote: On which, we should probably do this. --- Subject: module: Replace over-engineered nested sleep Since the introduction of the nested sleep warning; we've established that the occasional sleep inside a wait_event() is

[PATCH] module: Annotate nested sleep in resolve_symbol()

2015-02-10 Thread Peter Zijlstra
Because wait_event() loops are safe vs spurious wakeups we can allow the occasional sleep -- which ends up being very similar. Cc: Rusty Russell ru...@rustcorp.com.au Reported-by: Dave Jones da...@codemonkey.org.uk Signed-off-by: Peter Zijlstra (Intel) pet...@infradead.org --- kernel/module.c |

Re: [PATCH] module: Annotate nested sleep in resolve_symbol()

2015-02-10 Thread Peter Zijlstra
On which, we should probably do this. --- Subject: module: Replace over-engineered nested sleep Since the introduction of the nested sleep warning; we've established that the occasional sleep inside a wait_event() is fine. wait_event() loops are invariant wrt. spurious wakeups, and the

Re: [PATCH] module: Annotate nested sleep in resolve_symbol()

2015-02-10 Thread Rusty Russell
Dave Jones da...@codemonkey.org.uk writes: On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote: On which, we should probably do this. --- Subject: module: Replace over-engineered nested sleep Since the introduction of the nested sleep warning; we've established