Re: [PATCH] module: Clean up ro/nx after early module load failures

2014-08-15 Thread Andy Lutomirski
On Fri, Aug 15, 2014 at 11:49 AM, Rusty Russell wrote: > Andy Lutomirski writes: >> The commit >> >> 4982223e51e8 module: set nx before marking module MODULE_STATE_COMING. >> >> introduced a regression: if a module fails to parse its arguments or >> if mod_sysfs_setup fails, then the module's

Re: [PATCH] module: Clean up ro/nx after early module load failures

2014-08-15 Thread Rusty Russell
Andy Lutomirski writes: > The commit > > 4982223e51e8 module: set nx before marking module MODULE_STATE_COMING. > > introduced a regression: if a module fails to parse its arguments or > if mod_sysfs_setup fails, then the module's memory will be freed > while still read-only. Anything that re