Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

2021-02-10 Thread Jessica Yu
+++ Dan Carpenter [10/02/21 13:57 +0300]: Smatch complains that: kernel/module.c:4472 module_kallsyms_on_each_symbol() error: uninitialized symbol 'ret'. This warning looks like it could be correct if the list is empty. Fixes: 013c1667cf78 ("kallsyms: refactor

Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

2021-02-10 Thread Miroslav Benes
On Wed, 10 Feb 2021, Dan Carpenter wrote: > Smatch complains that: > > kernel/module.c:4472 module_kallsyms_on_each_symbol() > error: uninitialized symbol 'ret'. > > This warning looks like it could be correct if the list is > empty. > > Fixes: 013c1667cf78 ("kallsyms: refactor

Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

2021-02-10 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

[PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()

2021-02-10 Thread Dan Carpenter
Smatch complains that: kernel/module.c:4472 module_kallsyms_on_each_symbol() error: uninitialized symbol 'ret'. This warning looks like it could be correct if the list is empty. Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol") Signed-off-by: Dan