Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-21 Thread Richard Weinberger
Am 21.05.2015 um 10:05 schrieb Brian Norris: > On Thu, May 21, 2015 at 09:56:21AM +0200, Richard Weinberger wrote: >> On Wed, May 20, 2015 at 9:33 PM, Brian Norris >> wrote: >>> On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: Modify function blktrans_getgeo()'s return value to -E

Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-21 Thread Wenlin Kang
On 2015年05月21日 16:05, Brian Norris wrote: On Thu, May 21, 2015 at 09:56:21AM +0200, Richard Weinberger wrote: On Wed, May 20, 2015 at 9:33 PM, Brian Norris wrote: On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: Modify function blktrans_getgeo()'s return value to -ENXIO when dev->

Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-21 Thread Brian Norris
On Thu, May 21, 2015 at 09:56:21AM +0200, Richard Weinberger wrote: > On Wed, May 20, 2015 at 9:33 PM, Brian Norris > wrote: > > On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: > >> Modify function blktrans_getgeo()'s return value to -ENXIO when > >> dev->tr->getgeo == NULL. > >> > >>

Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-21 Thread Wenlin Kang
On 2015年05月21日 15:37, Brian Norris wrote: On Thu, May 21, 2015 at 02:49:38PM +0800, Wenlin Kang wrote: On 2015年05月21日 03:47, nick wrote: On 2015-05-20 03:33 PM, Brian Norris wrote: On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: Modify function blktrans_getgeo()'s return value to

Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-21 Thread Richard Weinberger
On Wed, May 20, 2015 at 9:33 PM, Brian Norris wrote: > Hi Wenlin, > > In the subject: > > s/rerurn/return/ > > On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: >> Modify function blktrans_getgeo()'s return value to -ENXIO when >> dev->tr->getgeo == NULL. >> >> We shouldn't make the ret

Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-21 Thread Brian Norris
On Thu, May 21, 2015 at 02:49:38PM +0800, Wenlin Kang wrote: > On 2015年05月21日 03:47, nick wrote: > >On 2015-05-20 03:33 PM, Brian Norris wrote: > >>On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: > >>>Modify function blktrans_getgeo()'s return value to -ENXIO when > >>>dev->tr->getgeo

Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-20 Thread Wenlin Kang
On 2015年05月21日 03:47, nick wrote: On 2015-05-20 03:33 PM, Brian Norris wrote: Hi Wenlin, In the subject: s/rerurn/return/ Thanks for pointing out this, I will modify it. On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: Modify function blktrans_getgeo()'s return value to -

Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-20 Thread Brian Norris
Hi Wenlin, In the subject: s/rerurn/return/ On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: > Modify function blktrans_getgeo()'s return value to -ENXIO when > dev->tr->getgeo == NULL. > > We shouldn't make the return value to 0 when dev->tr->getgeo == NULL, > because the function

[PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-12 Thread Wenlin Kang
Modify function blktrans_getgeo()'s return value to -ENXIO when dev->tr->getgeo == NULL. We shouldn't make the return value to 0 when dev->tr->getgeo == NULL, because the function blktrans_getgeo() has an output value "hd_geometry" which is usually used by some application, if return 0, it will ma