Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-05-08 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Tue, 7 May 2019 10:59:38 -0500: > On 5/7/19 10:49 AM, Richard Weinberger wrote: > > >> Hi all, > >> > >> Thanks a lot for this, Richard: > >> > >> https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=mtd%2Fnext&qt=grep&q=fall-through >

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-05-07 Thread Gustavo A. R. Silva
On 5/7/19 10:49 AM, Richard Weinberger wrote: >> Hi all, >> >> Thanks a lot for this, Richard: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=mtd%2Fnext&qt=grep&q=fall-through >> >> There are only two of these warnings left to be addressed in >> MTD[1]: >> >>

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-05-07 Thread Richard Weinberger
; , "linux-kernel" > , "Kees Cook" > Gesendet: Dienstag, 7. Mai 2019 16:54:12 > Betreff: Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs > Hi all, > > Thanks a lot for this, Richard: > > https://git.kernel.org/pub/scm/

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-05-07 Thread Gustavo A. R. Silva
Hi all, Thanks a lot for this, Richard: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=mtd%2Fnext&qt=grep&q=fall-through There are only two of these warnings left to be addressed in MTD[1]: > @@ -3280,12 +3280,14 @@ static void onenand_check_features(struct mtd_in

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-04-16 Thread Gustavo A. R. Silva
Hi Miquel, On 4/16/19 12:24 PM, Miquel Raynal wrote: > Hi Gustavo, > > "Gustavo A. R. Silva" wrote on Mon, 15 Apr > 2019 07:57:11 -0500: > >> Hi Miquel, >> >> On 4/15/19 3:44 AM, Miquel Raynal wrote: >>> Hi Gustavo, >>> >>> "Gustavo A. R. Silva" wrote on Wed, 10 Apr >>> 2019 16:16:51 -0500: >>

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-04-16 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Mon, 15 Apr 2019 07:57:11 -0500: > Hi Miquel, > > On 4/15/19 3:44 AM, Miquel Raynal wrote: > > Hi Gustavo, > > > > "Gustavo A. R. Silva" wrote on Wed, 10 Apr > > 2019 16:16:51 -0500: > > > >> Hi all, > >> > >> If no one cares I'll add this to my t

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-04-15 Thread Gustavo A. R. Silva
Hi Miquel, On 4/15/19 3:44 AM, Miquel Raynal wrote: > Hi Gustavo, > > "Gustavo A. R. Silva" wrote on Wed, 10 Apr > 2019 16:16:51 -0500: > >> Hi all, >> >> If no one cares I'll add this to my tree for 5.2. > > Which tree are you talking about? > This one: https://git.kernel.org/pub/scm/linux

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-04-15 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Wed, 10 Apr 2019 16:16:51 -0500: > Hi all, > > If no one cares I'll add this to my tree for 5.2. Which tree are you talking about? Please let the MTD maintainers take patches through their tree. We might be late but this is definitely not a good reas

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-04-10 Thread Kees Cook
On Fri, Feb 8, 2019 at 10:02 AM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mtd/chips/cfi_util.c: In function ‘cfi_build_cmd’: > drivers/mtd/ch

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-04-10 Thread Gustavo A. R. Silva
Hi all, If no one cares I'll add this to my tree for 5.2. Thanks -- Gustavo On 3/20/19 3:20 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? > > Thanks > -- > Gustavo > > On 2/8/19 12:02 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-03-20 Thread Gustavo A. R. Silva
On 3/20/19 6:25 PM, Richard Weinberger wrote: > Am Mittwoch, 20. März 2019, 22:23:21 CET schrieb Gustavo A. R. Silva: >> So, if this is too much of a burden for people, I can add all these >> MTD patches to my own tree for 5.2. > > Taking the patches via MTD is not a big deal, let's go that pat

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-03-20 Thread Richard Weinberger
Am Mittwoch, 20. März 2019, 22:23:21 CET schrieb Gustavo A. R. Silva: > So, if this is too much of a burden for people, I can add all these > MTD patches to my own tree for 5.2. Taking the patches via MTD is not a big deal, let's go that path. For you it is more work to send many patches and getti

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-03-20 Thread Gustavo A. R. Silva
On 3/20/19 4:05 PM, Richard Weinberger wrote: > Hi! > > Am Mittwoch, 20. März 2019, 21:20:51 CET schrieb Gustavo A. R. Silva: >> Hi all, >> >> Friendly ping: >> >> Who can take this? > > Hmmm, for MTD I think we can schedule these patches for the next merge window. > But I'm not sure whether t

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-03-20 Thread Richard Weinberger
Hi! Am Mittwoch, 20. März 2019, 21:20:51 CET schrieb Gustavo A. R. Silva: > Hi all, > > Friendly ping: > > Who can take this? Hmmm, for MTD I think we can schedule these patches for the next merge window. But I'm not sure whether these comments are a good solution. I much more prefer the compil

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-03-20 Thread Gustavo A. R. Silva
Hi all, Friendly ping: Who can take this? Thanks -- Gustavo On 2/8/19 12:02 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mtd/chips/cfi_ut

[PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-02-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/mtd/chips/cfi_util.c: In function ‘cfi_build_cmd’: drivers/mtd/chips/cfi_util.c:110:10: warning: this statement may fall through [-Wimplic