Re: [PATCH] mtd: chips: Replace printk() with pr_*() and define pr_fmt()

2018-03-13 Thread Andy Shevchenko
On Mon, Mar 12, 2018 at 7:02 PM, Arushi Singhal wrote: > Using pr_() is more concise than printk(KERN_). > This patch: > @@ -182,7 +184,7 @@ static void fixup_convert_atmel_pri(struct mtd_info *mtd) > - printk(KERN_ERR "atmel Features: %02x\n", atmel_pri.Features); > + pr_err("atmel

Re: [PATCH] mtd: chips: Replace printk() with pr_*() and define pr_fmt()

2018-03-12 Thread Joe Perches
On Mon, 2018-03-12 at 22:32 +0530, Arushi Singhal wrote: > Using pr_() is more concise than printk(KERN_). > This patch: > * Replace printks having a log level with the appropriate pr_*() macros. > * Define pr_fmt() to include relevant name. > * Remove redundant prefixes from pr_*() calls. > * Inde

[PATCH] mtd: chips: Replace printk() with pr_*() and define pr_fmt()

2018-03-12 Thread Arushi Singhal
Using pr_() is more concise than printk(KERN_). This patch: * Replace printks having a log level with the appropriate pr_*() macros. * Define pr_fmt() to include relevant name. * Remove redundant prefixes from pr_*() calls. * Indent the code where possible. Signed-off-by: Arushi Singhal --- driv